Skip to content

Conversation

@well-mannered-goat
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Added a struct to store the values instead of looking them up each time for each reloc.

Test plan

...

Closing issues

closes #5206


// XXX HACK ALERT!!!! full relro?? try to fix it
// will there always be .plt.got, what would happen if is .got.plt?
RzBinElfSection *s = Elf_(rz_bin_elf_get_section_with_name)(bin, ".plt.got");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of also adding some of such sections to the struct ?

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 68.18182% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.70%. Comparing base (d0a0b6e) to head (e67f614).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
librz/bin/format/elf/elf_imports.c 50.00% 3 Missing and 11 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/bin/format/elf/elf.c 79.00% <100.00%> (+1.82%) ⬆️
librz/bin/format/elf/elf_imports.c 66.05% <50.00%> (-1.39%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a0b6e...e67f614. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notxvilka notxvilka added this to the 0.9.0 milestone Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ELF - Refactor imports handling to improve performance

2 participants