integrated rz-svd into subprojects #5853
Draft
+41,139
−420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muqeet-Salam
requested review from
Rot127,
kazarmy,
ret2libc,
thestr4ng3r and
wargio
as code owners
wargio
reviewed
Jan 30, 2026
Member
There was a problem hiding this comment.
this file needs a copyright header
wargio
reviewed
Jan 30, 2026
Member
There was a problem hiding this comment.
Same here, this file needs a copyright header
wargio
reviewed
Jan 30, 2026
subprojects/rz-svd/Makefile
Outdated
wargio
reviewed
Jan 30, 2026
librz/meson.build
Outdated
Comment on lines
22
to
25
| rz_svd_proj = subproject( | ||
| 'rz-svd', | ||
| default_options: ['default_library=static', 'werror=false'] | ||
| ) |
wargio
requested changes
Jan 30, 2026
notxvilka
requested changes
Jan 30, 2026
Contributor
notxvilka
left a comment
notxvilka
left a comment
There was a problem hiding this comment.
Just reuse existing yxml subproject instead of adding one more copy
notxvilka
requested changes
Jan 30, 2026
librz/bin/p/bin_avr.c
Outdated
| /** | ||
| * Helper: Extract basename from filepath | ||
| */ | ||
| static const char *avr_path_basename(const char *path) { |
Contributor
There was a problem hiding this comment.
We have functions for that in librz/util
librz/bin/p/bin_avr.c
Outdated
| /** | ||
| * Helper: Convert string to lowercase in place | ||
| */ | ||
| static void avr_str_tolower(char *str) { |
Contributor
There was a problem hiding this comment.
Same, there is a function for that
librz/bin/p/bin_avr.c
Outdated
| /** | ||
| * Helper: Allocate and copy n bytes of a string | ||
| */ | ||
| static char *avr_str_ndup(const char *str, size_t n) { |
Contributor
There was a problem hiding this comment.
There is a function for that
Rot127
added
the
Requirements not met
Author
|
Hey, I made all the requested changes. The rz-svd build moving from librz/meson.build to meson.build is causing some dependency issues. To fix those I referenced librz/util directly which is why the compiling is showing 2 warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes. (no changes to api)RZ_API).Detailed description
Integrated rz-svd into subprojects, removed the hardcoded values from librz/bin/p/bin_avr.c and used the rz-svd plugin to detect the AVR device names.
...
Test plan
Build and compile the project to ensure rz-svd is added as a subproject, and then test an AVR ELF binary to ensure AVR plugin loads correctly, device detection works, hardcoded tables are no longer required
rz-bin -i path/to/.elf/file
rz-bin -s path/to/.elf/file
Closing issues
closes #5229
...