Simplify dependencies and build process#20
Open
midanosi wants to merge 6 commits intorjanjic:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First - thanks for creating this library, it's great! I work on a platform that we're planning to put this game on, as we've had many users ask for Solitaire in particular.
To the PR, basically - there's no need for webpack, babel anymore. Vite does everything out of the box.
The build output is slightly different, but works just the same, and is about 21kb instead of 43kb.
Note, I did aggressively remove all dependencies, so eslint is gone too.
I fully anticipate this PR not being merged in, and that's okay. I have plans to add keyboard controls (to avoid drag-and-drop), and configurable mode between 1-card draw and 3-card draw. And I'll continue pushing that to my fork.
Thanks again