Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 83 additions & 2 deletions .claude/agents/architect.md
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,87 @@ Add this section to all ADRs that introduce external dependencies:
| **High** | Major project to migrate | Proprietary data formats |
| **Critical** | Effectively permanent | Deep platform integration |

## Design Review Template (MANDATORY)

All DESIGN-REVIEW documents MUST use YAML frontmatter for automated parsing. The CI quality gate enforces blocking verdicts.

Save to: `.agents/architecture/DESIGN-REVIEW-[topic].md`

```markdown
---
status: "APPROVED | NEEDS_CHANGES | NEEDS_ADR | BLOCKED | REJECTED"
priority: "P0 | P1 | P2"
blocking: true | false
reviewer: "architect"
date: "YYYY-MM-DD"
pr: 0
issue: 0
---

# Design Review: [Topic]

## Executive Summary

**Verdict**: [STATUS]

[2-3 sentence summary of findings and recommendation]

## Context

[Problem statement and background]

## Evaluation

### [Section 1]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

### [Section 2]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

## Issues Discovered

| Issue | Priority | Category | Description |
|-------|----------|----------|-------------|
| [ID] | [P0/P1/P2] | [Category] | [Brief description] |

**Issue Summary**: P0: [N], P1: [N], P2: [N], Total: [N]

## Recommendations

1. [Recommendation with rationale]
2. [Recommendation with rationale]

## Verdict

**[STATUS]** with [conditions if any].

### Approval Conditions (if NEEDS_CHANGES)

1. [ ] [Condition 1]
2. [ ] [Condition 2]

## Handoff

**Orchestrator**: Route to **[agent]** for [next step].
```

### Status Definitions

| Status | Meaning | blocking Value |
|--------|---------|----------------|
| **APPROVED** | Design meets all criteria | `false` |
| **NEEDS_CHANGES** | Minor issues, can proceed with fixes | `false` |
| **NEEDS_ADR** | ADR required before proceeding | `true` |
| **BLOCKED** | Major issues, cannot proceed | `true` |
| **REJECTED** | Design fundamentally flawed | `true` |

### CI Enforcement

The `synthesis-panel-gate.yml` workflow parses frontmatter and blocks PRs when:

- `blocking: true` and status is NEEDS_ADR, BLOCKED, or REJECTED
- No `status` field present in frontmatter

## Architecture Review Process

### Pre-Planning Review
Expand Down Expand Up @@ -425,8 +506,8 @@ content: "# ADR-[Number]: [Title]\n\n**Statement**: ...\n\n**Evidence**: ...\n\n

`.agents/architecture/`

- `ADR-NNNN-[decision].md` - Architecture Decision Records
- `DESIGN-REVIEW-[topic].md` - Design review notes
- `ADR-NNNN-[decision].md` - Architecture Decision Records (use MADR 4.0 template)
- `DESIGN-REVIEW-[topic].md` - Design reviews (MUST use YAML frontmatter template above)

## Handoff Options

Expand Down
85 changes: 83 additions & 2 deletions .github/agents/architect.agent.md
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,87 @@ Accept that systems have lifespans and plan for replacement rather than indefini
- Business needs diverging from system capabilities
- Key knowledge holders leaving

## Design Review Template (MANDATORY)

All DESIGN-REVIEW documents MUST use YAML frontmatter for automated parsing. The CI quality gate enforces blocking verdicts.

Save to: `.agents/architecture/DESIGN-REVIEW-[topic].md`

```markdown
---
status: "APPROVED | NEEDS_CHANGES | NEEDS_ADR | BLOCKED | REJECTED"
priority: "P0 | P1 | P2"
blocking: true | false
reviewer: "architect"
date: "YYYY-MM-DD"
pr: 0
issue: 0
---

# Design Review: [Topic]

## Executive Summary

**Verdict**: [STATUS]

[2-3 sentence summary of findings and recommendation]

## Context

[Problem statement and background]

## Evaluation

### [Section 1]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

### [Section 2]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

## Issues Discovered

| Issue | Priority | Category | Description |
|-------|----------|----------|-------------|
| [ID] | [P0/P1/P2] | [Category] | [Brief description] |

**Issue Summary**: P0: [N], P1: [N], P2: [N], Total: [N]

## Recommendations

1. [Recommendation with rationale]
2. [Recommendation with rationale]

## Verdict

**[STATUS]** with [conditions if any].

### Approval Conditions (if NEEDS_CHANGES)

1. [ ] [Condition 1]
2. [ ] [Condition 2]

## Handoff

**Orchestrator**: Route to **[agent]** for [next step].
```

### Status Definitions

| Status | Meaning | blocking Value |
|--------|---------|----------------|
| **APPROVED** | Design meets all criteria | `false` |
| **NEEDS_CHANGES** | Minor issues, can proceed with fixes | `false` |
| **NEEDS_ADR** | ADR required before proceeding | `true` |
| **BLOCKED** | Major issues, cannot proceed | `true` |
| **REJECTED** | Design fundamentally flawed | `true` |

### CI Enforcement

The `synthesis-panel-gate.yml` workflow parses frontmatter and blocks PRs when:

- `blocking: true` and status is NEEDS_ADR, BLOCKED, or REJECTED
- No `status` field present in frontmatter

## Architecture Review Process

### Pre-Planning Review
Expand Down Expand Up @@ -555,8 +636,8 @@ Accept that systems have lifespans and plan for replacement rather than indefini

`.agents/architecture/`

- `ADR-NNNN-[decision].md` - Architecture Decision Records
- `DESIGN-REVIEW-[topic].md` - Design review notes
- `ADR-NNNN-[decision].md` - Architecture Decision Records (use MADR 4.0 template)
- `DESIGN-REVIEW-[topic].md` - Design reviews (MUST use YAML frontmatter template above)

## Handoff Options

Expand Down
85 changes: 83 additions & 2 deletions src/claude/architect.md
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,87 @@ Add this section to all ADRs that introduce external dependencies:
| **High** | Major project to migrate | Proprietary data formats |
| **Critical** | Effectively permanent | Deep platform integration |

## Design Review Template (MANDATORY)

All DESIGN-REVIEW documents MUST use YAML frontmatter for automated parsing. The CI quality gate enforces blocking verdicts.

Save to: `.agents/architecture/DESIGN-REVIEW-[topic].md`

```markdown
---
status: "APPROVED | NEEDS_CHANGES | NEEDS_ADR | BLOCKED | REJECTED"
priority: "P0 | P1 | P2"
blocking: true | false
reviewer: "architect"
date: "YYYY-MM-DD"
pr: 0
issue: 0
---

# Design Review: [Topic]

## Executive Summary

**Verdict**: [STATUS]

[2-3 sentence summary of findings and recommendation]

## Context

[Problem statement and background]

## Evaluation

### [Section 1]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

### [Section 2]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

## Issues Discovered

| Issue | Priority | Category | Description |
|-------|----------|----------|-------------|
| [ID] | [P0/P1/P2] | [Category] | [Brief description] |

**Issue Summary**: P0: [N], P1: [N], P2: [N], Total: [N]

## Recommendations

1. [Recommendation with rationale]
2. [Recommendation with rationale]

## Verdict

**[STATUS]** with [conditions if any].

### Approval Conditions (if NEEDS_CHANGES)

1. [ ] [Condition 1]
2. [ ] [Condition 2]

## Handoff

**Orchestrator**: Route to **[agent]** for [next step].
```

### Status Definitions

| Status | Meaning | blocking Value |
|--------|---------|----------------|
| **APPROVED** | Design meets all criteria | `false` |
| **NEEDS_CHANGES** | Minor issues, can proceed with fixes | `false` |
| **NEEDS_ADR** | ADR required before proceeding | `true` |
| **BLOCKED** | Major issues, cannot proceed | `true` |
| **REJECTED** | Design fundamentally flawed | `true` |

### CI Enforcement

The `synthesis-panel-gate.yml` workflow parses frontmatter and blocks PRs when:

- `blocking: true` and status is NEEDS_ADR, BLOCKED, or REJECTED
- No `status` field present in frontmatter

## Architecture Review Process

### Pre-Planning Review
Expand Down Expand Up @@ -425,8 +506,8 @@ content: "# ADR-[Number]: [Title]\n\n**Statement**: ...\n\n**Evidence**: ...\n\n

`.agents/architecture/`

- `ADR-NNNN-[decision].md` - Architecture Decision Records
- `DESIGN-REVIEW-[topic].md` - Design review notes
- `ADR-NNNN-[decision].md` - Architecture Decision Records (use MADR 4.0 template)
- `DESIGN-REVIEW-[topic].md` - Design reviews (MUST use YAML frontmatter template above)

## Handoff Options

Expand Down
85 changes: 83 additions & 2 deletions src/copilot-cli/architect.agent.md
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,87 @@ When reviewing an ADR:
- [ ] Related ADRs are linked
```

## Design Review Template (MANDATORY)

All DESIGN-REVIEW documents MUST use YAML frontmatter for automated parsing. The CI quality gate enforces blocking verdicts.

Save to: `.agents/architecture/DESIGN-REVIEW-[topic].md`

```markdown
---
status: "APPROVED | NEEDS_CHANGES | NEEDS_ADR | BLOCKED | REJECTED"
priority: "P0 | P1 | P2"
blocking: true | false
reviewer: "architect"
date: "YYYY-MM-DD"
pr: 0
issue: 0
---

# Design Review: [Topic]

## Executive Summary

**Verdict**: [STATUS]

[2-3 sentence summary of findings and recommendation]

## Context

[Problem statement and background]

## Evaluation

### [Section 1]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

### [Section 2]
[Analysis with [PASS]/[FAIL]/[WARNING] indicators]

## Issues Discovered

| Issue | Priority | Category | Description |
|-------|----------|----------|-------------|
| [ID] | [P0/P1/P2] | [Category] | [Brief description] |

**Issue Summary**: P0: [N], P1: [N], P2: [N], Total: [N]

## Recommendations

1. [Recommendation with rationale]
2. [Recommendation with rationale]

## Verdict

**[STATUS]** with [conditions if any].

### Approval Conditions (if NEEDS_CHANGES)

1. [ ] [Condition 1]
2. [ ] [Condition 2]

## Handoff

**Orchestrator**: Route to **[agent]** for [next step].
```

### Status Definitions

| Status | Meaning | blocking Value |
|--------|---------|----------------|
| **APPROVED** | Design meets all criteria | `false` |
| **NEEDS_CHANGES** | Minor issues, can proceed with fixes | `false` |
| **NEEDS_ADR** | ADR required before proceeding | `true` |
| **BLOCKED** | Major issues, cannot proceed | `true` |
| **REJECTED** | Design fundamentally flawed | `true` |

### CI Enforcement

The `synthesis-panel-gate.yml` workflow parses frontmatter and blocks PRs when:

- `blocking: true` and status is NEEDS_ADR, BLOCKED, or REJECTED
- No `status` field present in frontmatter

## Architectural Principles

- **Consistency**: Follow established patterns
Expand Down Expand Up @@ -555,8 +636,8 @@ Accept that systems have lifespans and plan for replacement rather than indefini

`.agents/architecture/`

- `ADR-NNNN-[decision].md` - Architecture Decision Records
- `DESIGN-REVIEW-[topic].md` - Design review notes
- `ADR-NNNN-[decision].md` - Architecture Decision Records (use MADR 4.0 template)
- `DESIGN-REVIEW-[topic].md` - Design reviews (MUST use YAML frontmatter template above)

## Handoff Options

Expand Down
Loading
Loading