Skip to content

fix querySelector in Form focusOnError when id includes dots #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix querySelector in Form focusOnError when id includes dots #4280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7902b3e
fix querySelector in Form focusOnError when id includes dots
jroebu14 Aug 20, 2024
48ce4c2
Merge branch 'main' into fix-invalid-query-selector-in-focus-on-error
heath-freenome Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ export default class Form<
let field = this.formElement.current.elements[elementId];
if (!field) {
// if not an exact match, try finding an input starting with the element id (like radio buttons or checkboxes)
field = this.formElement.current.querySelector(`input[id^=${elementId}`);
field = this.formElement.current.querySelector(`input[id^="${elementId}"`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a straightforward change. Are you willing to add a test to verify it was fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heath-freenome apologies, I made this PR right before going on vacation. I see it's been merged but would you still like me to add a unit test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heath-freenome apologies, I made this PR right before going on vacation. I see it's been merged but would you still like me to add a unit test?

@jroebu14 If you could, that would be great! Hope you had a great vacation

}
if (field && field.length) {
// If we got a list with length > 0
Expand Down