Skip to content

Conversation

cewald
Copy link

@cewald cewald commented Dec 16, 2024

Reasons for making this change

fixes #4357

This reverts commit ff46301

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question and a small change to the CHANGELOG.md and you are good to go

@heath-freenome
Copy link
Member

@cewald It looks like something in the utils tests are breaking. Can you please take a look... Also there are a few questions/concerns to address

@cewald
Copy link
Author

cewald commented Jan 13, 2025

I did not had time for checking the tests yet – but I actually "just reverted the changes". So there might be changes in the meantime that rely on the new version of code. Idk. I dont think I find time to debug those tests anytime soon, as I am not that much into the code and would need some time for research.

@heath-freenome
Copy link
Member

Closing in favor of #4723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty enum is blocking dependency after v5.5.1

2 participants