Bug: Antd radio is not disabled when disabled is set in ui schema #4519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@Nareshe31 Great fix! Thanks for that. In order to ensure this doesn't get regressed in the future, would you be open to adding a new test in the |
|
Sure @heath-freenome. I will add new test and update the PR |
|
Also, don't forget to update the |
|
@Nareshe31 how close are you to adding the new test? I'm about to cut a new release and was hoping to get this in |
|
@Nareshe31 NVM, I will add the tests myself and merge this ticket. |
heath-freenome
approved these changes
Mar 12, 2025
heath-freenome
added a commit
that referenced
this pull request
Mar 12, 2025
There is another place where the ESM build needs an update to for proper import of AJV standalone code. - Added a new `ajvReplacer` that adds `/index.js` to the end of `ajv/dist/standalone` - Updated `@rjsf/validator-ajv8` to add the `ajvReplacer` to the `tsconfig.replacer.json` and `tsc.build.json` - Also fixed up some formatting around imports in a few files - Updated `.gitignore` to add `ajvReplacer.js` - Updated `formTests.ts` to add tests for the fix in [#4519](#4519) - Updated the snapshots for these new tests - Updated the `CHANGELOG.md` accordingly
8 tasks
heath-freenome
added a commit
that referenced
this pull request
Mar 13, 2025
* Fixed ESM issue with validator-ajv8 There is another place where the ESM build needs an update to for proper import of AJV standalone code. - Added a new `ajvReplacer` that adds `/index.js` to the end of `ajv/dist/standalone` - Updated `@rjsf/validator-ajv8` to add the `ajvReplacer` to the `tsconfig.replacer.json` and `tsc.build.json` - Also fixed up some formatting around imports in a few files - Updated `.gitignore` to add `ajvReplacer.js` - Updated `formTests.ts` to add tests for the fix in [#4519](#4519) - Updated the snapshots for these new tests - Updated the `CHANGELOG.md` accordingly * - Fixed comment
|
Hey @heath-freenome , thanks for merging the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Antd radio is not disabled when disabled is set in ui schema
Fixes #4481
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.