Skip to content

Conversation

v1ack
Copy link
Contributor

@v1ack v1ack commented Mar 31, 2025

Reasons for making this change

Fixes #4525

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

"jsx": "react-jsx"
"jsx": "react-jsx",
// Skip because of antd inner ts errors
"skipLibCheck": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without skip fails with errors

../../node_modules/antd/node_modules/rc-picker/lib/PickerPanel/index.d.ts:40:18 - error TS2430: Interface 'SinglePickerPanelProps<DateType>' incorrectly extends interface 'BasePickerPanelProps<DateType>'.
  Types of property 'defaultValue' are incompatible.
    Type 'DateType | null | undefined' is not assignable to type 'DateType | undefined'.
      Type 'null' is not assignable to type 'DateType | undefined'.

40 export interface SinglePickerPanelProps<DateType extends object = any> extends BasePickerPanelProps<DateType> {
                    ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@rc-component/qrcode/lib/index.d.ts:1:1 - error TS1383: Only named exports may use 'export type'.

1 export type * from './interface';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@heath-freenome
Copy link
Member

heath-freenome commented Apr 3, 2025

@v1ack Turns out I am making these changes in the rjsf-v6 beta. And I see that the playground is adding a lot of margin in between fields? Do you know how to improve that?

@heath-freenome heath-freenome merged commit 94080d2 into rjsf-team:main Apr 3, 2025
5 checks passed
@v1ack v1ack deleted the fix-antd-ts branch April 4, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript error in antd theme

2 participants