chore: Replace Lerna with Nx #4546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elated documentation
nickgros
commented
Apr 3, 2025
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| - run: git update-index --assume-unchanged .npmrc | ||
| - run: npx lerna publish from-package --yes | ||
| - run: npx nx release publish |
There was a problem hiding this comment.
I tried this locally with --dry-run and it seemed to work, but we won't know for sure until we try to publish a release.
nickgros
commented
Apr 3, 2025
| @@ -1,38 +1,57 @@ | |||
| { | |||
There was a problem hiding this comment.
Config file was auto-migrated by the Nx upgrade tool
nickgros
commented
Apr 3, 2025
Comment on lines
-9
to
-10
| "publish-repo": "lerna publish", | ||
| "changed": "lerna changed", |
There was a problem hiding this comment.
Removed these scripts as I don't believe we use them
nickgros
commented
Apr 3, 2025
Comment on lines
+34
to
+37
| "@nx/js": "^20.7.1", | ||
| "@swc-node/register": "^1.9.1", | ||
| "@swc/core": "^1.5.7", | ||
| "@swc/helpers": "^0.5.11", |
There was a problem hiding this comment.
@nx/js (and these swc packages) are required to use nx release version. These were auto-installed when I ran nx add @nx/js
nickgros
commented
Apr 3, 2025
|
|
||
| Make sure you use [semver](https://semver.org/) for version numbering when selecting the version. | ||
| The `npx lerna version` command will create a new version tag and push it to GitHub. | ||
| The `npx nx release version --git-tag` command will create a new version tag and push it to GitHub. |
There was a problem hiding this comment.
This git tag includes the v at the start of the tag name. I think this is different from Lerna, but I don't think it will affect our tag scripts. We may need to tweak this a bit if it doesn't work.
heath-freenome
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated scripts related documentation
Reasons for making this change
Lerna is deprecated and has been replaced by Nx
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.