-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add Mantine theme - rjsf-v6 #4560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@heath-freenome All requested changes have been applied, please check and let me know if there is anything else |
@zfarhad Can you also fix the build issues |
@heath-freenome All the code cleanups applied I tried to fix the build, but I get this error for all packages, not just mantine: `
` |
@zfarhad Just merged another theme. Can you rebase and update? Also, I see the same build errors when I locally do |
I've rebased and updated the branch. Also fixed the lint errors and warnings. But I still get errors on build! I think the problem comes from the utils package, when I just try to build it I have these errors:
|
packages/mantine/package.json
Outdated
"@babel/preset-typescript": "^7.23.3", | ||
"@rjsf/core": "^6.0.0-alpha.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you have the three @mantine
libraries included here as dev dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need them for the tests right?
@zfarhad what version of node are you using? What happens if you first checkout |
packages/mantine/package.json
Outdated
"@rjsf/validator-ajv8": "^6.0.0-alpha.0", | ||
"@types/jest": "^29.5.12", | ||
"@types/lodash": "^4.14.202", | ||
"@types/react": "^18.2.58", | ||
"@types/react-dom": "^18.2.19", | ||
"@types/react-test-renderer": "^18.0.7", | ||
"atob": "^2.1.2", | ||
"babel-jest": "^29.7.0", | ||
"eslint": "^8.56.0", | ||
"jest": "^29.7.0", | ||
"jest-environment-jsdom": "^29.7.0", | ||
"nanoid": "^3.3.7", | ||
"react": "^18.2.0", | ||
"react-dom": "^18.2.0", | ||
"react-test-renderer": "^18.2.0", | ||
"rimraf": "^5.0.5", | ||
"rollup": "^3.29.4", | ||
"typescript": "^4.9.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged a package.json
cleanup PR that eliminates the need for these:
"@rjsf/validator-ajv8": "^6.0.0-alpha.0", | |
"@types/jest": "^29.5.12", | |
"@types/lodash": "^4.14.202", | |
"@types/react": "^18.2.58", | |
"@types/react-dom": "^18.2.19", | |
"@types/react-test-renderer": "^18.0.7", | |
"atob": "^2.1.2", | |
"babel-jest": "^29.7.0", | |
"eslint": "^8.56.0", | |
"jest": "^29.7.0", | |
"jest-environment-jsdom": "^29.7.0", | |
"nanoid": "^3.3.7", | |
"react": "^18.2.0", | |
"react-dom": "^18.2.0", | |
"react-test-renderer": "^18.2.0", | |
"rimraf": "^5.0.5", | |
"rollup": "^3.29.4", | |
"typescript": "^4.9.5" | |
"@rjsf/validator-ajv8": "^6.0.0-alpha.0", | |
"atob": "^2.1.2", | |
"eslint": "^8.56.0", | |
"nanoid": "^5.1.5" |
packages/mantine/package.json
Outdated
"devDependencies": { | ||
"@babel/core": "^7.23.9", | ||
"@babel/plugin-proposal-class-properties": "^7.18.6", | ||
"@babel/plugin-proposal-optional-chaining": "^7.21.0", | ||
"@babel/preset-env": "^7.23.9", | ||
"@babel/preset-react": "^7.23.3", | ||
"@babel/preset-typescript": "^7.23.3", | ||
"@rjsf/core": "^6.0.0-alpha.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"devDependencies": { | |
"@babel/core": "^7.23.9", | |
"@babel/plugin-proposal-class-properties": "^7.18.6", | |
"@babel/plugin-proposal-optional-chaining": "^7.21.0", | |
"@babel/preset-env": "^7.23.9", | |
"@babel/preset-react": "^7.23.3", | |
"@babel/preset-typescript": "^7.23.3", | |
"@rjsf/core": "^6.0.0-alpha.0", | |
"devDependencies": { | |
"@rjsf/core": "^6.0.0-alpha.0", |
@zfarhad hopefully when you rebase onto the latest |
@zfarhad sorry about the close. You'll have to rebase on main now and deal with the conflicts. |
@zfarhad Can you rebase to |
Co-authored-by: Heath C <[email protected]> Co-authored-by: Abdallah Al-Soqatri <[email protected]> Co-authored-by: Kevin Burnett <[email protected]> Co-authored-by: Marek Bodinger <[email protected]> Co-authored-by: Mehdi Salem <[email protected]> Co-authored-by: Jonasz Wiącek <[email protected]> Co-authored-by: Bogdan Savluk <[email protected]> Co-authored-by: Christian Wendt <[email protected]> Co-authored-by: Ben Lambert <[email protected]> Co-authored-by: David R. Bild <[email protected]> Co-authored-by: Ariqun <[email protected]> Co-authored-by: Shivam Anand Murmu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shubham Biswas <[email protected]> Co-authored-by: popmanhe <[email protected]> Co-authored-by: Yuki Aoki <[email protected]> Co-authored-by: Xiangcheng Kuo <[email protected]> Co-authored-by: Bart van Andel <[email protected]> Co-authored-by: Laurent Direr <[email protected]> Co-authored-by: Vegard Stenvik <[email protected]> Co-authored-by: Appie <[email protected]> Co-authored-by: Oren Forer <[email protected]> Co-authored-by: Marcus Penn <[email protected]> Co-authored-by: joachimhagheim <[email protected]> Co-authored-by: MarekBodingerBA <[email protected]> Co-authored-by: momesana <[email protected]> Co-authored-by: Martti Roitto <[email protected]> fix(utils): direct lodash function import to improve bundling on library client side (rjsf-team#3976) fix: rjsf-team#3961 resolve all recurse list for object properties (rjsf-team#3981) fix gap in outline when label is hidden (rjsf-team#3984) Fix: Expose the internal `ajv` variable in the validator implementation classes (rjsf-team#3991) Fixes: rjsf-team#3972 indirectly by exposing the `ajv` variable for use in the issue Fix: Change FormHelperText usage with @mui/material to render divs (rjsf-team#4032) Fixes rjsf-team#4031 by switching the render component for `FormHelperText` to be `div` fix: Added support for anyOf/oneOf in uiSchema (rjsf-team#4055) Fixes rjsf-team#4039 by updating `MultiSchemaField` to properly support `anyOf`/`oneOf` arrays in the `uiSchema` Fix checkbox with 0 as a value was unselectable in antd (rjsf-team#4068) Fixed rjsf-team#4067 by properly dealing with enums that have 0 as a value Fix potential XSS in the preview button of FileWidget (rjsf-team#4065) Fix: Make 'ui:rows' option work with chakra-ui for textarea elements rjsf-team#4070 (rjsf-team#4078) Fix typo in ErrorsListTemplate example (rjsf-team#4087) Fix rjsf-team#4080 by moving `base64` encoder/decoder from `@rjsf/utils` to playground (rjsf-team#4093) Fix: Error state not resetting when schema changes (rjsf-team#4079) (rjsf-team#4103) Fix noImplicitAny error (rjsf-team#4106) Fixes: [WARNING] Duplicate key "include" in object literal [duplicate-object-key] (rjsf-team#4114) Fixes: Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>. (rjsf-team#4117) Fix documentation to add missing Form imports (rjsf-team#4131) Fix rjsf-team#4127 to add missing `Form` import in documentation Fix: filename should be bold (rjsf-team#4125) Fix: use correct ConfigProvider context by using named imports (rjsf-team#4132) Fix 4134 by filtering out bad DOM props (rjsf-team#4140) Fixes: rjsf-team#4134 by updating the spreading of props onto the `TextField` to remove bad DOM fields Fixed Programmatic submit not working properly in Firefox (rjsf-team#4150) Fix Maximum call stack size exceeded in findSchemaDefinition (rjsf-team#4123)
Co-authored-by: Heath C <[email protected]> Co-authored-by: Abdallah Al-Soqatri <[email protected]> Co-authored-by: Kevin Burnett <[email protected]> Co-authored-by: Marek Bodinger <[email protected]> Co-authored-by: Mehdi Salem <[email protected]> Co-authored-by: Nick Grosenbacher <[email protected]> Co-authored-by: Abdallah Al-Soqatri <[email protected]> Co-authored-by: Jonasz Wiącek <[email protected]> Co-authored-by: Bogdan Savluk <[email protected]> Co-authored-by: Christian Wendt <[email protected]> Co-authored-by: Ben Lambert <[email protected]> Co-authored-by: David R. Bild <[email protected]> Co-authored-by: Ariqun <[email protected]> Co-authored-by: Shivam Anand Murmu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shubham Biswas <[email protected]> Co-authored-by: popmanhe <[email protected]> Co-authored-by: Yuki Aoki <[email protected]> Co-authored-by: Xiangcheng Kuo <[email protected]> Co-authored-by: Bart van Andel <[email protected]> Co-authored-by: Laurent Direr <[email protected]> Co-authored-by: Vegard Stenvik <[email protected]> Co-authored-by: Appie <[email protected]> Co-authored-by: Oren Forer <[email protected]> Co-authored-by: Marcus Penn <[email protected]> Co-authored-by: joachimhagheim <[email protected]> Co-authored-by: MarekBodingerBA <[email protected]> Co-authored-by: momesana <[email protected]> Co-authored-by: Martti Roitto <[email protected]> Co-authored-by: Serge van den Oever <[email protected]> Co-authored-by: Enzo Ferey <[email protected]> Co-authored-by: Skyf0l <[email protected]> Co-authored-by: Jaejoon Han <[email protected]> Co-authored-by: とまとみ <[email protected]> Co-authored-by: Daniel Todd <[email protected]> Co-authored-by: Dmitry Dzhus <[email protected]> Co-authored-by: Alexander Kachkaev <[email protected]> Co-authored-by: shaddollxz <[email protected]> Co-authored-by: Changyu Geng <[email protected]> Co-authored-by: Helen Lin <[email protected]> Co-authored-by: solimant <[email protected]> Co-authored-by: David Li <[email protected]> fix(utils): direct lodash function import to improve bundling on library client side (rjsf-team#3976) fix: rjsf-team#3961 resolve all recurse list for object properties (rjsf-team#3981) fix gap in outline when label is hidden (rjsf-team#3984) Fix: Expose the internal `ajv` variable in the validator implementation classes (rjsf-team#3991) Fixes: rjsf-team#3972 indirectly by exposing the `ajv` variable for use in the issue Fix: Change FormHelperText usage with @mui/material to render divs (rjsf-team#4032) Fixes rjsf-team#4031 by switching the render component for `FormHelperText` to be `div` fix: Added support for anyOf/oneOf in uiSchema (rjsf-team#4055) Fixes rjsf-team#4039 by updating `MultiSchemaField` to properly support `anyOf`/`oneOf` arrays in the `uiSchema` Fix checkbox with 0 as a value was unselectable in antd (rjsf-team#4068) Fixed rjsf-team#4067 by properly dealing with enums that have 0 as a value Fix potential XSS in the preview button of FileWidget (rjsf-team#4065) Fix: Make 'ui:rows' option work with chakra-ui for textarea elements rjsf-team#4070 (rjsf-team#4078) Fix typo in ErrorsListTemplate example (rjsf-team#4087) Fix rjsf-team#4080 by moving `base64` encoder/decoder from `@rjsf/utils` to playground (rjsf-team#4093) Fix: Error state not resetting when schema changes (rjsf-team#4079) (rjsf-team#4103) Fix noImplicitAny error (rjsf-team#4106) Fixes: [WARNING] Duplicate key "include" in object literal [duplicate-object-key] (rjsf-team#4114) Fixes: Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>. (rjsf-team#4117) Fix documentation to add missing Form imports (rjsf-team#4131) Fix rjsf-team#4127 to add missing `Form` import in documentation Fix: filename should be bold (rjsf-team#4125) Fix: use correct ConfigProvider context by using named imports (rjsf-team#4132) Fix 4134 by filtering out bad DOM props (rjsf-team#4140) Fixes: rjsf-team#4134 by updating the spreading of props onto the `TextField` to remove bad DOM fields Fixed Programmatic submit not working properly in Firefox (rjsf-team#4150) Fix Maximum call stack size exceeded in findSchemaDefinition (rjsf-team#4123) fix typos in constants.ts, Form.tsx (rjsf-team#4185) Fix mui imports in docs (rjsf-team#4218) fix] Resetting number fields should check the entire string when deciding to leave the input text alone (rjsf-team#4202) (rjsf-team#4220) Fixed performance issue with large schema dependencies and oneOf (rjsf-team#4203) (rjsf-team#4204) Fixed performance issue rjsf-team#4203 fix(core): field ui-options higher priority (rjsf-team#4212) fix(antd): disabled property of options of antd theme (rjsf-team#4216) fix: omitExtraData on submit and on validateForm (rjsf-team#4228) Fix IdSchema and PathSchema types (rjsf-team#4196) fixes rjsf-team#4236 Fix rjsf-team#4197 in various themes by showing empty option in SelectWidget when appropriate (rjsf-team#4200) fix: xss when rendering schema errors (rjsf-team#4256) fix 4215 and 4260 by updating optionsList() to take a uiSchema (rjsf-team#4263) Fixes rjsf-team#4215 and rjsf-team#4260 by supporting alternate titles for enums and anyOf/oneOf lists via the uiSchema Fixed Changelog (rjsf-team#4269)
* Implemented the GridTemplate for all themes - In all themes except `@rjsf/core`: - Implemented the `GridTemplate` using the theme specific grid, adding them to the `templates` in the Registry - In `@rjsf/core` cleaned up the documentation for the already implemented `GridTemplate` - In `@rjsf/mui` switched to using the `Grid2` component instead of the deprecated `Grid` - Updated the `CHANGELOG_V6.md` accordingly * - Fixed the styling for the `mui` `ObjectFieldTemplate` * - Fixed the MUI snapshots
* Added new utility functions needed by LayoutGridForm Adding new functions to `@rjsf/utils` to support the upcoming `LayoutGridForm` - Updated `@rjsf/utils` to add new types and functions in support of the `LayoutGridForm` - Updated the `utility-functions.md` documentation for the new functions - Updated the `v6.x upgrade guide.md` documentation for the new functions and types - Updated the `CHANGELOG_V6.md` for the new functions and types * - Fixed build and removed console.log * Update packages/utils/src/schema/findSelectedOptionInXxxOf.ts - Reviewer feedback
* Add playground examples for LayoutGrid for each theme Updated the `playground` so that each theme has an example of the `LayoutGridField` usage - In `@rjsf/utils` added a `browser` section to the `package.json` to support `getTestIds()` working properly in a browser - Updated the `getTestIds()` to refactor out `getTestIdsBrowser()` and export it from the new `indexBrowser.ts` - Updated `package.json` to build `indexBrowser.js` for each export type - In `@rjsf/core` made a few changes to support the playground examples: - In `LayoutMultiSchemaField` added support for the hiding of labels as well as extracting the `placeholder` from the UiSchema - In `GridTemplate` removed the explicit adding of the `row` class, leaving that up to the users of the `UiSchema` - In `@rjsf/fluentui-rc` made a few changes to support the playground examples: - In `GridTemplate` switched to using the `GridShim` displaying it only when `columns` or `rows` are provided, otherwise simply exporting a `div` due to the CSS Grid - In `RadioWidget` implemented support for `inline` styling of the radio elements - In `playground` implemented the `Layout Grid` example with the following changes: - Updated the `vite.config.ts` to pull the `utils` classes from the `indexBrowser` - Added the new `UiSchemaForTheme` type, overriding the `uiSchema` for `Sample` to be `UiSchema` or `UiSchemaForTheme` - Renamed `Selector` to `SampleSelector`, adding the `selectedSample` as a prop, removing the use of the `current` state in favor of `selectedSample` - Also changed the `onSelected()` callback to take a `sampleName: string` rather than `data: any` - Updated `Header` to replace `load` with `onSampleSelected` adding `sampleName: string`, serializing `sampleName` on share - Also, passed `sampleName` as `selectedSample` and `onSampleSelected` to the `SampleSelector` - Updated `EditorProps` to take `data: any` for `onChange` - Updated `EditorsProps` to take a new `hasUiSchemaGenerator: boolean`, using it to provide a different title for the `UiSchema` section when true - Updated `Playground` add two new state variables, `uiSchemaGenerator` and `sampleName` - Updated `onThemeSelected()` to update the `uiSchema` to the one generated from the `uiSchemaGenerator(theme)` if that function is defined in state - Updated `load()` to take an additional `sampleName` prop, using it to set the currently selected sample and to set the `uiSchemaGenerator` if `samples[sampleName]` has one - Also, set the `uiSchema` to a generated one if the incoming `uiSchema` is a function and adding a undefined check for the `validator` - Added a new `onSampleSelected()` which calls `load()` with the selected sample and `sampleName` - Updated `DemoFrame` and `app.ts` to rename `material-ui-5` to `mui` - Added a new `layoutGrid.ts` and exported it from the `samples/index.ts` * - Fixed test * Update CHANGELOG_v6.md * - Fix `MultiSchemaField` to pass `id` in `onChange` * - Renamed `MuiV5Theme` to `MuiTheme`
* feat: migrated from v5 to v6 * chore: minor style fix for disabled state for select * chore: rename `shad-lib` to `lib`, also updated test snapshots for adding type to `add button` and `icon button` * updated package*.json after versioning * updated package*.json after versioning * feat: grid template implementation * feat: migrated from v5 to v6 * chore: rename `shad-lib` to `lib`, also updated test snapshots for adding type to `add button` and `icon button` * updated package*.json after versioning * updated package*.json after versioning * feat: grid template implementation * chore: update test snapshot * chore: update README.md for rjsf/core versioning * chore: improve ESM support (tsconfig.build.json and package.json) * chore: add missing jsdoc for all component * chore: remove console.log when finish building css files * fix: only imports what necessary from React/radix primitive * chore: rearrange import sort order * chore: remove blank line in gitignore, lint jest.config, reduce jsdom dep to be on equal ground to project * updated package*.json after versioning * Update .gitignore Co-authored-by: Heath C <[email protected]> * Update packages/shadcn/src/AddButton/AddButton.tsx Co-authored-by: Heath C <[email protected]> * Update packages/shadcn/build-css.cjs Co-authored-by: Heath C <[email protected]> * Update packages/shadcn/README.md Co-authored-by: Heath C <[email protected]> * chore: add jsdoc for icon button components * refactor: simplify conditional rendering in SelectWidget component * chore: rename build-css.cjs to build-css.js and update package.json script * chore: add JSDoc comments for Alert component * chore: add JSDoc comments for Badge component * chore: add JSDoc comments for Button component * chore: add JSDoc for Checkbox component * chore: add JSDoc for Command components * chore: add JSDoc for FancyMultiSelect, FancySelect and default select components * chore: add JSDoc return type for Alert, Badge, Button, and Command components * chore: add JSDoc for Input, Label, and Textarea components * chore: add JSDoc for Dialog, RadioGroup, Separator, and Slider components * chore: proofreading JSDoc and improve documentation for AddButton, FancyMultiSelect, FancySelect, and FieldTemplate components * Update packages/shadcn/.gitignore Co-authored-by: Heath C <[email protected]> * chore: refine JSDoc for RangeWidget component and adjust type annotations * Update packages/shadcn/src/AddButton/AddButton.tsx Co-authored-by: Heath C <[email protected]> --------- Co-authored-by: tuanminh <[email protected]> Co-authored-by: Heath C <[email protected]>
…elated documentation
…support (rjsf-team#4547) * Chore: add "type": "module" to all package.json files for better ESM support To improve ESM support, the `package.json` files for all public repos were updated to add `type: module` - Installed `tsx` in `package.json` as a dev dependency - Replaced all `babel.config.js` files with `babel.config.json` since `jest` assumes `.js` files are ESM not CJS - Replaced all `jest.config.js` files with` `jest.config.json` since `jest` assumes `.js` files are ESM not CJS - In all `package.json` files where a replacer was compiled, renamed them to `.cjs` to since they are `commonjs` - Updated the `tsconfig.build.json` files to change the replace extension to `.cjs` - Updated the `.gitignore` to ignore replacers with `.cjs` along with `.js` - In `@rjsf/validator-ajv8` switched the `compileTestSchema.js` to `compileTestSchema.ts` to replace `require` with `import` - Used `tsx` to run the file rather than `node` - Also generated `.cjs` files rather than `.js` since they are `commonjs` - In `@rjsf/shadcn` switched `build-css.js` to `build-css.ts`, replacing `require` with `import` - Used `tsx` to run the file rather than `node` - Also renamed `postcss.config.js` to `postcss.config.json` * - Switched to cross-build safe `move-file-cli` rather than `mv` * - Removed antd v4 support * - Updated `CHANGELOG_v6.md`
…sf-team#4548) * Feature: Add LayoutHeaderField to support headers in Layout Grids Sometimes people will want a header for a section in a `LayoutGridField` and this provides support for it - Added a new `LayoutHeaderField` to the list of fields in `core` that simply renders a `TitleFieldTemplate` - Added 100% RTL tests for the component - Updated the `layoutGrid` example in the `playground` to add an example of using it - Updated the `shadcn` `GridTemplate` to remove some hard-coded styling that made the `LayoutHeaderField` usage look really bad - Updated the `layoutGrid` to add the additional styling to make the example still work for `shadcn` - Updated the `CHANGELOG_v6.md` and `custom-widgets-fields.md` to document the new fields * Update packages/core/test/LayoutHeaderField.test.tsx Co-authored-by: Nick Grosenbacher <[email protected]> --------- Co-authored-by: Nick Grosenbacher <[email protected]>
* feat(daisyui): enhance UI components with improved visual hierarchy Redesigned form templates with connected card styling, consistent spacing, and improved layout. Added proper visual hierarchy for nested elements, optimized control button positioning, and implemented cross-browser date/time widgets. Applied DaisyUI utility classes consistently for a cohesive interface while maintaining full RJSF functionality. * Making docs truthy. * PR feedback. PR feedback. PR review * Very close - need to fix calendar rendering Looking good. * Build fixes * Code review comments * PR comments * (feat) Adds core/rating widget and demo Build cleanup * Lint free * Addressing PR comments. Fixes selects. Uses Fieldsets instead of custom arrays. Uses join for buttons when appropriate. Calendar fix * * Improves default Rating widget * Updated .github templates to add: fluent-rc, shadcn, daisy * Addresses all PR comments * Updates README * useCallbacks * Pre-tests * Tests. Builds. * MacOS path and file casing issue resolved. Should fix build. * Button IDs, import ordering, etc. * Updating Docusaurus and fixing the build. * Apply suggestions from code review Last bits --------- Co-authored-by: Heath C <[email protected]>
* Fixing daisyui build The daisyui merge broke the build, attempting to fix this - Updated the `package*.json` to remove the dependencies - Updated the daisyui snapshots * - Bumped packages in hope it fixes things * - Bumped `package-lock.json` by deleting and reinstalling * - Updated linting and docs for new themes * - bumped build tools * - Tried remmoving package-lock.json and `node_modules` for `shadcn`
* Fixed rjsf-team#4564 by checking process type Fixed rjsf-team#4564 to eliminate typing issue * - Removed the `indexBrowser` implementation since the typechecking handles it much more simply
…sing them to a UI component
- Review all templates and widgets - Add FileWidget - Add GridTemplate
@heath-freenome |
branches: [main, rjsf-v6] | ||
pull_request: | ||
branches: [main] | ||
branches: [main, rjsf-v6] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can revert these changes now that the rjsf-v6
branch is merged and deleted
branches: [ "main", "rjsf-v6" ] | ||
pull_request: | ||
branches: [ "main" ] | ||
branches: [ "main", "rjsf-v6" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can revert these changes now that the rjsf-v6
branch is merged and deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this file and then add a line for 6.0.0-beta.7
with the addition of your new theme with something like:
# 6.0.0-beta.6
## @rjsf/mantine
- Added new theme!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted, go ahead and remove it
"dependencies": { | ||
"@restart/hooks": "^0.6.2", | ||
"@restart/ui": "^1.9.4", | ||
"ajv": "^8.17.1", | ||
"ajv-keywords": "^5.1.0", | ||
"uncontrollable": "^9.0.0" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These belong as devDependencies
in your theme's package.json
. If you need the @restart
stuff as dependencies in your theme, do that
{displayLabel && rawDescription && ( | ||
<Text size='sm' mt={5}> | ||
{description} | ||
</Text> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SchemaField
renders the DescriptionTemplate
as description
, not sure you want it double wrapped in Text
:
{displayLabel && rawDescription && ( | |
<Text size='sm' mt={5}> | |
{description} | |
</Text> | |
)} | |
{displayLabel && rawDescription && description} |
<RemoveButton | ||
id={buttonId<T>(id, 'remove')} | ||
iconType='sm' | ||
className='array-item-remove' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className='array-item-remove' | |
className='rjsf-array-item-remove' |
onClick={[Function]} | ||
> | ||
<div | ||
aria-controls=":r3:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did these come from?!
}, | ||
}, | ||
}, | ||
'daisy-ui': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you delete this since I moved it below and this make it a duplicate
stylesheet: '//cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css', | ||
theme: BootstrapTheme, | ||
}, | ||
'react-bootstrap': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also duplicated right above so just remove it too
@zfarhad How can we help you get this finished? |
@zfarhad I hope everything is ok. Let us know when you are ready to get this theme merged |
I would love to have this too! |
@Algirdyz It looks like the author of the PR disappeared. You are welcome to pick up the work in your own PR to get it over the line. |
I've started a draft PR here: |
Closing in favor of #4692 |
Reasons for making this change
[Please describe them here]
Added a new theme using Mantine UI library (@mantine/core, @mantine/hooks, @mantine/dates) for react-jsonschema-form v6, following the PR #4496 and addressing rjsf-v6.
This theme provides a modern, customizable UI component set that integrates well with RJSF's form generation capabilities.
The Mantine theme offers:
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.