Fix markdown in descriptions rendering #4597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
force-pushed
the
reimplement-4405
branch
from
8c18612 to
4c94b93
Compare
heath-freenome
commented
May 3, 2025
| </div> | ||
| ); | ||
| } | ||
| return ( |
There was a problem hiding this comment.
This is why the <p> turned to <div> in the snapshots.
This was referenced May 3, 2025
heath-freenome
commented
May 4, 2025
|
This also fixes #4527, which I opened some time ago. This is great! Thank you very much! |
Reimplements #4405 in v6 In the fields of type `object` and type `boolean`, markdown will be rendered in the description when `enableMarkdownInDescription` is set to `true`. Issue reporting this bug: #3975 Previous PR to add the feature: #3665 The result: <img width="1484" alt="Screenshot 2024-12-01 at 18 44 54" src="https://github.com/user-attachments/assets/46bcf958-2da3-4706-a855-825fd73e1b27">
heath-freenome
force-pushed
the
reimplement-4405
branch
from
b563969 to
3b1ce6a
Compare
heath-freenome
commented
May 5, 2025
| return localStorage.getItem('daisyui-theme') || 'cupcake'; | ||
| } catch { | ||
| return 'cupcake'; | ||
| function DaisyUIFrameComponent(props: DaisyUIFrameProviderProps & { document?: Document }) { |
There was a problem hiding this comment.
By creating the component with a useEffect() the tailwind styles are removed when the theme is unselected in the playground
nickgros
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4527
Reimplements #4405 in v6
In the fields of type
objectand typeboolean, markdown will be rendered in the description whenenableMarkdownInDescriptionis set totrue.Issue reporting this bug: #3975
Previous PR to add the feature: #3665
The result:
mddesc.mov
Reasons for making this change
[Please describe them here]
If this is related to existing tickets, include links to them as well. Use the syntax
fixes #[issue number](ex:fixes #123).If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.