-
Notifications
You must be signed in to change notification settings - Fork 2.3k
restore getChakra calls #4620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore getChakra calls #4620
Conversation
b58debe
to
a63b906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I don't have full context but want to check if the chakra props should be spread last so that they can override the existing props? For example, I might want to change the margin-bottom on BaseInputTemplate
a63b906
to
5be1e58
Compare
i've changed it |
5be1e58
to
bd47e17
Compare
@antpaw does it make sense to also add it to the |
Can we export the |
That is a fair request. @antpaw can you export it along with the |
249890e
to
644bca8
Compare
@heath-freenome please review, i had to cast its as |
@antpaw Looks good, and I totally forgot to have you add an entry to the |
@heath-freenome done |
Reasons for making this change
I've added the uiSchema props via
getChakra
call back in#4389 (comment)
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.