Skip to content

restore getChakra calls #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2025
Merged

restore getChakra calls #4620

merged 4 commits into from
May 14, 2025

Conversation

@antpaw
Copy link
Contributor

@antpaw antpaw commented May 13, 2025

Reasons for making this change

I've added the uiSchema props via getChakra call back in

#4389 (comment)

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@antpaw antpaw mentioned this pull request May 13, 2025
Closed
1 task
@antpaw antpaw force-pushed the restore-getChakra-calls branch from b58debe to a63b906 Compare May 13, 2025 07:07
thesnups
thesnups reviewed May 13, 2025
View reviewed changes
Copy link

@thesnups thesnups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't have full context but want to check if the chakra props should be spread last so that they can override the existing props? For example, I might want to change the margin-bottom on BaseInputTemplate

@antpaw antpaw force-pushed the restore-getChakra-calls branch from a63b906 to 5be1e58 Compare May 13, 2025 08:46
@antpaw
Copy link
Contributor Author

antpaw commented May 13, 2025

i've changed it

@antpaw antpaw force-pushed the restore-getChakra-calls branch from 5be1e58 to bd47e17 Compare May 13, 2025 08:47
@heath-freenome
Copy link
Member

@antpaw does it make sense to also add it to the AltDateWidget on the Box with the flex? Also, you have some Typescript issues

@thesnups
Copy link

Can we export the getChakra util function for package consumers so that they can use it in their custom templates?

@heath-freenome
Copy link
Member

heath-freenome commented May 13, 2025 •
edited
Loading

Can we export the getChakra util function for package consumers so that they can use it in their custom templates?

That is a fair request. @antpaw can you export it along with the ChakraUiSchema type that is already being exported in the main index.ts file?

@antpaw antpaw force-pushed the restore-getChakra-calls branch from 249890e to 644bca8 Compare May 14, 2025 09:44
@antpaw
Copy link
Contributor Author

antpaw commented May 14, 2025

@heath-freenome please review, i had to cast its as any as its not possible to use the CheckboxesWidget wrapped in <Field>

@heath-freenome
Copy link
Member

@antpaw Looks good, and I totally forgot to have you add an entry to the CHANGELOG.md file. Do that and we are good to go

@antpaw
Copy link
Contributor Author

antpaw commented May 14, 2025

@heath-freenome done

@heath-freenome heath-freenome merged commit 0754b1c into rjsf-team:main May 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heath-freenome heath-freenome heath-freenome approved these changes

+1 more reviewer

@thesnups thesnups thesnups left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antpaw @heath-freenome @thesnups