Fix 4623 by properly handling chakra-ui's onChange for single select #4627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed rjsf-team#4623 by having the single select version return the element in the returned array - Updated chakra-ui's `SelectWidget` to return a single value from the array
heath-freenome
commented
May 17, 2025
Comment on lines
-48
to
-50
| value.map((item) => { | ||
| return item; | ||
| }), |
There was a problem hiding this comment.
This seemed unnecessary since it basically returned the same thing as value
nickgros
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixed #4623 by having the single select version return the element in the returned array
SelectWidgetto return a single value from the arrayChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.