Fix bug in LayoutGridField related to global options in the uiSchema #4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in `LayoutGridField` where it was looking at the wrong key for the `UiSchema`'s global options - Updated `LayoutGridField` to use the `UI_GLOBAL_OPTIONS_KEY` constant from `@rjsf/util` instead of its own constant, which had the wrong key name - Also fixed the `GlobalUISchemaOptions` to extend from `GenericObjectType` to support user-defined values for their customizations - Updated the tests and `CHANGELOG.md` accordingly
schen-fn
approved these changes
May 16, 2025
schen-fn
reviewed
May 16, 2025
Co-authored-by: Serena Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes a bug in
LayoutGridFieldwhere it was looking at the wrong key for theUiSchema's global optionsLayoutGridFieldto use theUI_GLOBAL_OPTIONS_KEYconstant from@rjsf/utilinstead of its own constant, which had the wrong key nameGlobalUISchemaOptionsto extend fromGenericObjectTypeto support user-defined values for their customizationsCHANGELOG.mdaccordinglyChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.