Skip to content

Conversation

antpaw
Copy link
Contributor

@antpaw antpaw commented May 27, 2025

Reasons for making this change

fixes #4619

after:
Screenshot 2025-05-27 at 10 00 02

before:
Screenshot 2025-05-27 at 10 05 11

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@antpaw Can you update the test snapshots using npm run test:update so that we can merge this

@heath-freenome
Copy link
Member

@antpaw Just need you to fix the build and we can merge

@antpaw antpaw force-pushed the chakra-validation-styling branch from a1832a6 to 17e15d0 Compare June 8, 2025 19:14
@antpaw
Copy link
Contributor Author

antpaw commented Jun 8, 2025

@heath-freenome done

@antpaw antpaw force-pushed the chakra-validation-styling branch from 17e15d0 to c161bc5 Compare June 10, 2025 07:43
Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to look at and then I'll approve/merge

CHANGELOG.md Outdated

- Added documentation for the new `MultiSchemaFieldTemplate`

## @rjsf/chakra-ui
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consolidate this with the new @rjsf/chakra-ui above. Also, since we just created a new MultiSchemaFieldTemplate for chakra-ui, can you take a look at that and see if you wanted to improve its UI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done

@heath-freenome heath-freenome merged commit 50b6d74 into rjsf-team:main Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Chakra composition for field + help text

2 participants