-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Improve visual styling of error validation boxes #4641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve visual styling of error validation boxes #4641
Conversation
@antpaw Can you update the test snapshots using |
@antpaw Just need you to fix the build and we can merge |
a1832a6
to
17e15d0
Compare
@heath-freenome done |
17e15d0
to
c161bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing to look at and then I'll approve/merge
CHANGELOG.md
Outdated
|
||
- Added documentation for the new `MultiSchemaFieldTemplate` | ||
|
||
## @rjsf/chakra-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consolidate this with the new @rjsf/chakra-ui
above. Also, since we just created a new MultiSchemaFieldTemplate
for chakra-ui
, can you take a look at that and see if you wanted to improve its UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, done
Reasons for making this change
fixes #4619
after:

before:

Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update
to update snapshots, if needed.