[feat] Add MultiSchemaFieldTemplate #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MultiSchemaFieldTemplate - Refactor MultiSchemaField to use MultiSchemaFieldTemplate - Add implementation of MultiSchemaFieldTemplate to each theme - Documentation & migration guide for MultiSchemaFieldTemplate - Update snapshots
heath-freenome
approved these changes
Jun 9, 2025
| /** The rendered widget used to select a schema option */ | ||
| selector: ReactNode; | ||
| /** The rendered SchemaField for the selected schema option */ | ||
| optionSchemaField: ReactNode; |
There was a problem hiding this comment.
I wonder if it's better if this is optional?
There was a problem hiding this comment.
MultiSchemaField will always pass an optionSchemaField to the template, even if it's null | undefined (which are both valid ReactNode types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes UI bug in many themes, potentially addresses #4662
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.