Always make all references absolute in nested bundled schemas #4683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
reviewed
Jul 11, 2025
|
@GlassOfWhiskey We are waiting for a rebase as well as responses to our queries |
GlassOfWhiskey
force-pushed
the
fix-nested-refs
branch
from
0bf3356 to
dca2acb
Compare
|
Can you rebase and make sure things are all set. I also want to wait for @nickgros to come back from vacation to look at this again as well. |
This commit adjusts all internal references of a bundled schema to be absolute, allowing subschemas to be correctly resolved.
GlassOfWhiskey
force-pushed
the
fix-nested-refs
branch
from
709c33a to
68f994b
Compare
|
Just did it. |
nickgros
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts all internal references of a bundled schema to be absolute, allowing subschemas to be correctly resolved.
Reasons for making this change
Field renderers often resolve references on subsets of the original subschema, with are always validated against the whole root schema. However, bundled schemas may contain relative references, which should be resolved against an internal
$idfield. To resolve this problem, all references in nested bundled schema are now transformed into absolute references, so that they are always resolvable against the root schema.