Skip to content

Conversation

Sheday
Copy link
Contributor

@Sheday Sheday commented Jul 23, 2025

Reasons for making this change

The labels in the RadioWidget for the shadcn theme don't do anything when clicked on. I would expect when clicking a label that the option gets selected.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

heath-freenome commented Aug 11, 2025

@Sheday Can you fix the build issues using npm run cs-format

@heath-freenome
Copy link
Member

@Sheday whoops you also have to update the snapshots using the npm run test:update command

@heath-freenome
Copy link
Member

heath-freenome commented Aug 15, 2025

@Sheday You are so close to getting this fix merged... Just rebase, fix the conflicts and update the snapshots!

@heath-freenome heath-freenome merged commit b4c4b53 into rjsf-team:main Aug 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants