Chore: Convert some core tests to typescript using jest #4890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency and to support react 19 conversion, upgraded a set of tests in core to typescript and jest
- In `@rjsf/core`, added a typescript version of `test_utils.js` named `testUtils.tsx`
- Renamed the `setup-jest-env.js` file to `.ts` updating it in the `jest.config.json`
- Renamed the following test files to `.tsx`, converting to using `jest` and `@testing-library` constructs and matchers:
- `ArrayFieldTemplate`, `FieldTemplate`, `FormContext`, `NullField`, `NumberField`, `ObjectFieldTemplate`, `allOf`, `const`, `ifthenelse` and `withTheme`
- The `DescriptionField` and `TitleField` tests changed enough so that they appear as a delete/new rather than rename
- Updated the `CHANGELOG.md` accordingly
nickgros
approved these changes
Dec 2, 2025
| Simulate.click(node.querySelector('.rjsf-array-item-add')); | ||
| const button = node.querySelector('.rjsf-array-item-add'); | ||
| expect(button).toBeInTheDocument(); | ||
| fireEvent.click(button!); |
Contributor
There was a problem hiding this comment.
This click (which we were already doing) is meaningless since we don't assert/verify anything afterwards
Comment on lines
+42
to
+48
| // Use rerender function instead | ||
| // export function setProps(comp: Form, newProps: Omit<FormProps, 'validator'>) { | ||
| // render(createElement(Form, { validator, ...newProps }), { | ||
| // container: comp.ref.current.formElement.current.parentNode, | ||
| // }); | ||
| // } | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| // Use rerender function instead | |
| // export function setProps(comp: Form, newProps: Omit<FormProps, 'validator'>) { | |
| // render(createElement(Form, { validator, ...newProps }), { | |
| // container: comp.ref.current.formElement.current.parentNode, | |
| // }); | |
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
For consistency and to support react 19 conversion, upgraded a set of tests in core to typescript and jest
@rjsf/core, added a typescript version oftest_utils.jsnamedtestUtils.tsxsetup-jest-env.jsfile to.tsupdating it in thejest.config.json.tsx, converting to usingjestand@testing-libraryconstructs and matchers:ArrayFieldTemplate,BooleanField,FieldTemplate,FormContext,NullField,NumberFieldObjectFieldTemplate,allOf,const,ifthenelse,withTheme,validateDescriptionFieldandTitleFieldtests changed enough so that they appear as a delete/new rather than renameCHANGELOG.mdaccordinglyChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.