fix: update output directory in config.ini and enhance URL handling#26
Open
mvidaldev wants to merge 2 commits intorkwyu:mainfrom
Open
fix: update output directory in config.ini and enhance URL handling#26mvidaldev wants to merge 2 commits intorkwyu:mainfrom
mvidaldev wants to merge 2 commits intorkwyu:mainfrom
Conversation
Owner
|
A few questions:
Just want to understand the rationale and see if centralizing URL logic in the regex modules would be cleaner. |
Author
|
I will make changes, it is my first time contributing to an open source project. |
…ive downloader services
Author
|
I've made changes as asked, I've tested slideshare and it had some errors processing itens too, we have fixed the problem, I could not test evergrand because every link fails to me. Could you provide me some valid links to test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a folder to save downloads, for easy pourpose.
Fixed url handling to ignore subdomains on the npm start.