add error handling for crawl4ai markdown generator#33
Open
add error handling for crawl4ai markdown generator#33
Conversation
Contributor
There was a problem hiding this comment.
can you move the block list to agent/utils/crawl4ai_block_list.txt and soft link it here in the rl repo (to make it compatible with the original repo)?
| physicsworld.com | ||
| wiley.com | ||
| hindawi.com | ||
| jhu.edu |
Contributor
There was a problem hiding this comment.
Ok randomly saw this -- there is a bunch of .edu domain names removed here -- I think this is list is obtained for crawling for pretraining data, but not sure if it is ideal to exclude them here.
| error_str = str(e) | ||
| # Check if it's a 500 error related to markdown_generator serialization | ||
| if "500" in error_str or "model_dump" in error_str: | ||
| print(f"[crawl4ai] markdown_generator caused error, retrying without it: {error_str[:100]}") |
Contributor
There was a problem hiding this comment.
Curious if removing markdown generator can actually avoid this issue? (b/c sometimes it's just b/c downloading the original webpage may take a bit longer and then retrying it again after a few seconds can actually fix the issue) But maybe there are outliers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.