Conversation
mergify
bot
requested review from
a team,
yeukfu and
ziyiwu9494
and removed request for
a team
Contributor
Author
|
Benchmarks should be done in a few days. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
- Coverage 91.56% 91.52% -0.04%
==========================================
Files 197 198 +1
Lines 10927 10979 +52
Branches 1387 1393 +6
==========================================
+ Hits 10005 10049 +44
- Misses 663 669 +6
- Partials 259 261 +2 ☔ View full report in Codecov by Sentry. |
ryanjulian
reviewed
Oct 29, 2020
ryanjulian
reviewed
Oct 29, 2020
Member
ryanjulian
left a comment
ryanjulian
left a comment
There was a problem hiding this comment.
How are the benchmark results?
krzentner
approved these changes
Oct 30, 2020
Contributor
krzentner
left a comment
krzentner
left a comment
There was a problem hiding this comment.
Nice. This is a pretty clean implementation.
maliesa96
force-pushed
the
per_dqn
branch
2 times, most recently
from
4e708fd to
bf2b104
Compare
Contributor
Author
|
Currently rerunning some of the benchmarks (some were interrupted), will report back once they're done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1489.