Skip to content

First draft for general nspace function#181

Open
Bisaloo wants to merge 20 commits intormaia:masterfrom
Bisaloo:nspace
Open

First draft for general nspace function#181
Bisaloo wants to merge 20 commits intormaia:masterfrom
Bisaloo:nspace

Conversation

@Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Nov 20, 2019

Fix #179

Breaking changes:

  • dispace(): none

  • trispace(): x, y

    • edit xlim and ylim in triplot()
  • tcspace(): x, y, z, r.vec

    • edit achrbot in tetraplot()

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Aug 13, 2025

Note for the future if I don't manage to get this PR over the finish line now: we cannot really use this approach in the exisiting trispace() / triplot(), tcspace() etc. as they use a different reference simplex to convert the quantum catches to coordinates in the colour space.

In theory, it shouldn't matter as these values are arbitrary and any rotation, translation, etc. can be applied.

But:

  • There is a long history of using these references and x, y, z might now have sense of their own because of this
  • I'm not sure all users are aware that these values don't mean much in the absolute

@Bisaloo Bisaloo marked this pull request as ready for review August 14, 2025 12:36
@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Aug 14, 2025

There is some back and forth in the commit history because I tried to already use it internally in trispace() / tcspace() but I think that was a distraction.

The function is already useful as it is so let's try to get this merged and we can always revisit & refactor later.

@Bisaloo Bisaloo requested a review from thomased August 14, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalise dispace()/trispace()/tcspace() to higher dimensions

1 participant