Conversation
Bisaloo
commented
Aug 1, 2025
| x <- i - center | ||
| y <- j - center | ||
| freq <- round(sqrt(x^2 + y^2)) / width_pix * (width_pix / width_deg) | ||
| freq <- round(sqrt(x^2 + y^2)) / width_deg |
Collaborator
Author
There was a problem hiding this comment.
This doesn't seem right. We need to double check the equations before merging.
Collaborator
Author
There was a problem hiding this comment.
This is what they use in the original code:
@thomased, I seem to remember that you are in touch with the original authors. Am I missing something or is it worth getting in touch to ask if the code is correct?
Bisaloo
force-pushed
the
simplification-2025-08
branch
from
38fe221 to
a947e8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.