Skip to content

Add Redis backend for Perfetto traces#5247

Closed
rmosolgo wants to merge 21 commits intomasterfrom
perfetto-backend
Closed

Add Redis backend for Perfetto traces#5247
rmosolgo wants to merge 21 commits intomasterfrom
perfetto-backend

Conversation

@rmosolgo
Copy link
Copy Markdown
Owner

Extracted from #5244 -- I'm trying to figure out where the failing snapshot test came from...

track_uuid: fid,
)
unsubscribe_from_active_support_notifications
if @save_trace_mode && m.context[:trace_mode] == @save_trace_mode
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instance method end_execute_multiplex missing tests for lines 196, 197, 198, 199, 200, 196, 196 (coverage: 0.375)

@rmosolgo
Copy link
Copy Markdown
Owner Author

Ok, I found the error. Fiber[:graphql_flow_stack] was being left as an empty array from one run to the next. Then later runs would use that top-level array instead of a per-fiber array created later on. I think there is actually more jankiness here, but unsetting that before each run will contain the jankiness to one query.

I think better behavior for the flow stack would be:

  • When pushing a flow packet, push it to this fiber's stack (not a parent fiber)
  • When reading a flow packet, read it from this fiber's stack, or a parent fiber (the current fiber may have been created to finish work started on another fiber)

But I'm not going to implement that now.

@rmosolgo rmosolgo closed this Feb 21, 2025
@rmosolgo rmosolgo deleted the perfetto-backend branch April 1, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant