Skip to content

Add an optional argument_definition parameter for required_validator #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an optional argument_definition parameter for required_validator #5459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/graphql/schema/argument.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def initialize(arg_name = nil, type_expr = nil, desc = nil, required: true, type
end

if required == :nullable
self.owner.validates(required: { argument: arg_name })
self.owner.validates(required: { argument: arg_name, argument_definition: self })
end

if definition_block
Expand Down
4 changes: 3 additions & 1 deletion lib/graphql/schema/validator/required_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ class Validator
class RequiredValidator < Validator
# @param one_of [Array<Symbol>] A list of arguments, exactly one of which is required for this field
# @param argument [Symbol] An argument that is required for this field
# @param argument_definition [GraphQL::Schema::Argument] The argument definition or instance, which may contain attributes needed by the validator
# @param message [String]
def initialize(one_of: nil, argument: nil, message: nil, **default_options)
def initialize(one_of: nil, argument: nil, argument_definition: nil, message: nil, **default_options)
@argument_definition = argument_definition
@one_of = if one_of
one_of
elsif argument
Expand Down
Loading