Fix unquoted shell parameter substitutions in cutadapt_paired rule#83
Merged
agillen merged 2 commits intoconfig_update_zshfrom Jan 28, 2026
Merged
Fix unquoted shell parameter substitutions in cutadapt_paired rule#83agillen merged 2 commits intoconfig_update_zshfrom
agillen merged 2 commits intoconfig_update_zshfrom
Conversation
Co-authored-by: agillen <4809242+agillen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on zsh-dependent config revamp PR
Fix unquoted shell parameter substitutions in cutadapt_paired rule
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses shell quoting issue in the
cutadapt_pairedrule where unquoted parameter substitutions in test expressions cause errors when parameters are empty or contain special characters.Changes
{params.bc_cut}in shell test:[ -z "{params.bc_cut}" ]{params.bc_length1}in shell test:[ -z "{params.bc_length1}" ]Without quotes, empty parameters cause
[to receive missing arguments, and special characters can trigger word-splitting. This is standard shell escaping for zsh/bash test expressions.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.