prepare 0.7.2 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JannesSP
commented
Sep 8, 2025
JannesSP
commented
- I do not know anymore in which version, but in some 0.9.x dorado version, the shift and scale values were taken from the raw DACS values instead of the pA signal
- First I thought this was a change between the old r9 pore to the new r10 and rna004 flowcells, but I noticed, that the sm and sd values in the basecalled bam changed back to normalize the pA signal. Now I just check if the shift is above 400, then the raw DACS signal is taken for normalization, otherwise the pA signal is taken.
- I do not know anymore in which version, but in some 0.9.x dorado version, the shift and scale values were taken from the raw DACS values instead of the pA signal - First I thought this was a change between the old r9 pore to the new r10 and rna004 flowcells, but I noticed, that the sm and sd values in the basecalled bam changed back to normalize the pA signal. Now I just check if the shift is above 400, then the raw DACS signal is taken for normalization, otherwise the pA signal is taken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.