Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
📝 WalkthroughWalkthroughThis pull request modifies the codecov workflow in the GitHub Actions configuration to download coverage artifacts and refactor the coverage file processing pipeline. The workflow now reads coverage results from a subdirectory and applies an awk-based filter to rewrite file paths instead of the previous sed-based approach. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow to correctly aggregate and upload Go coverage data to Codecov, addressing the reported 0% coverage issue by ensuring paths in the combined coverprofile map to files in this repository.
Changes:
- Ensure the Codecov upload job checks out the repository and downloads the
coverageartifact into a known directory. - Combine
*.outfiles from the downloaded artifact and rewrite coverprofile paths so they are repository-relative (including the nestedprotoc_pluginsGo module).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/linux.yml:
- Around line 88-99: The awk block that transforms summary.txt into
summary.filtered.txt currently only prints lines matching NR==1 or the two
/^github\.com\/roadrunner-server\/grpc\/v5\// and
/^github\.com\/roadrunner-server\/grpc\/protoc_plugins\/v5\// patterns, which
silently drops any other lines; update the awk script (the multi-line awk in the
workflow that reads summary.txt and writes summary.filtered.txt) to include a
default action that prints unmatched lines and emits a warning (e.g., print the
line and a diagnostic to stderr or prefixed comment) so unrecognised module
paths are preserved and visible rather than lost.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
===========================================
+ Coverage 0 68.31% +68.31%
===========================================
Files 0 7 +7
Lines 0 464 +464
===========================================
+ Hits 0 317 +317
- Misses 0 113 +113
- Partials 0 34 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit