Skip to content

Conversation

@rustatian
Copy link
Member

@rustatian rustatian commented Oct 2, 2025

Reason for This PR

  • stable release cycle

Description of Changes

πŸš€ v2025.1.4 πŸš€

Changelog

🎯 Core

  • ✨ Fileserver Plugin: The Fileserver plugin has been restored to the standard bundle because of the resolution of all CVEs in its dependency, GoFiber.
  • ✨ Green Tea Garbage Collector: The Green Tea garbage collector has been disabled by default after receiving several bug reports related to its use. For more details, see the Go RFC.
  • ✨ Automaxprocs: The automaxprocs library from Uber has been removed, as Go 1.25 now includes this functionality natively.

πŸ“¦ Velox

  • ✨ Velox: Updated to version v2025.1.4 with an updated template that removed the automaxprocs dependency.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • New Features
    • Added a built-in File Server plugin for serving static assets.
  • Documentation
    • Added AI-assistant guidance (CLAUDE.md).
    • Removed outdated contributor onboarding documentation (AGENTS.md).
  • Chores
    • Updated multiple dependencies (AWS SDK, Google APIs, Redis, NATS, Fiber, etc.).
  • CI/Build
    • Simplified build/release configuration by removing an experimental Go environment flag; no functional changes expected.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian requested a review from Copilot October 2, 2025 15:37
@rustatian rustatian self-assigned this Oct 2, 2025
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Oct 2, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Removed GOEXPERIMENT=greenteagc from CI and Docker builds, deleted AGENTS.md, added CLAUDE.md, registered fileserver.Plugin in the container plugin list, and updated go.mod to add github.com/roadrunner-server/fileserver/v5 plus multiple dependency version bumps.

Changes

Cohort / File(s) Summary
Build & CI env cleanup
.github/workflows/release.yml, Dockerfile
Removed GOEXPERIMENT=greenteagc environment setting from release workflow and Dockerfile; other build flags and LDFLAGS unchanged.
Documentation updates
AGENTS.md, CLAUDE.md
Deleted AGENTS.md; added CLAUDE.md with guidance for using Claude Code and repo dev notes.
Plugin integration
container/plugins.go
Added import for github.com/roadrunner-server/fileserver/v5 and inserted fileserver.Plugin into the Plugins() return list.
Dependencies
go.mod
Added github.com/roadrunner-server/fileserver/v5 and bumped numerous indirect and direct dependencies (Google APIs/protobufs, AWS SDK v2 modules, go-redis v9-related modules, NATS, Fiber, fasthttp, brotli, and others).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Init as Container Init
  participant Cfg as Config Loader
  participant FS as Fileserver Plugin
  participant Core as RR Core

  Note right of Init: Startup sequence (changed)
  Init->>Cfg: Load configuration (plugins list)
  Cfg-->>Init: Plugins list (includes Fileserver)
  Init->>FS: Instantiate & Initialize
  FS-->>Init: Initialized
  Init->>Core: Register plugin handlers
  Core-->>Init: Registered
  Note right of FS: Fileserver now participates in runtime lifecycle
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • release: v2024.2Β #1980 β€” Similar change adding a plugin import and inserting a plugin into Plugins(); overlaps with container/plugins.go edits.
  • release: v2025.1.3Β #2234 β€” Related to toggling/removing GOEXPERIMENT=greenteagc in CI/Docker; directly connected to build env changes.
  • release: v2024.3.3Β #2123 β€” Touches go.mod and adds/updates fileserver/v5 and related dependency bumps.

Suggested labels

R-stable

Suggested reviewers

  • wolfy-j

Poem

A rabbit nudges code with nimble paw,
Greentea spills β€” the Docker sighs in awe.
A fileserver hops into the stack,
New deps scurry, then settle back.
Docs and builds align β€” release on cue. πŸ‡βœ¨

Pre-merge checks and finishing touches

βœ… Passed checks (3 passed)
Check name Status Explanation
Title Check βœ… Passed The pull request title β€œrelease: v2025.1.4” concisely and accurately summarizes the main intent of this changeset as a new version release, following common conventions for release PRs without extraneous detail.
Docstring Coverage βœ… Passed No functions found in the changes. Docstring coverage check skipped.
Description Check βœ… Passed The PR description matches the repository’s template by including all required sections: a clear Reason for This PR, a Description of Changes with detailed changelog entries, a License Acceptance confirmation under MIT, and a fully completed PR checklist. Each template heading is present and populated, and the checklist items are marked as completed. The structure adheres to the prescribed format, so the description check passes.
✨ Finishing touches
  • πŸ“ Generate Docstrings
πŸ§ͺ Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/v2025.1.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This release (v2025.1.4) focuses on dependency updates and removes experimental Go features. The main purpose is to align with Go 1.25 capabilities and clean up experimental build settings.

  • Remove automaxprocs uber tool dependency (no longer needed with Go 1.25)
  • Revert GOEXPERIMENT with greenteagc setting from builds
  • Add fileserver plugin support and update various dependencies

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updates multiple dependencies and adds fileserver plugin dependency
container/plugins.go Registers the new fileserver plugin in the plugin container
Dockerfile Removes GOEXPERIMENT=greenteagc environment variable
CLAUDE.md Adds comprehensive project documentation for Claude AI assistant
AGENTS.md Removes old agent guidelines documentation
.github/workflows/release.yml Removes GOEXPERIMENT=greenteagc from release build process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 36.26%. Comparing base (40e6e40) to head (13068db).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2240      +/-   ##
==========================================
+ Coverage   36.20%   36.26%   +0.05%     
==========================================
  Files          18       18              
  Lines        1091     1092       +1     
==========================================
+ Hits          395      396       +1     
  Misses        657      657              
  Partials       39       39              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Valery Piashchynski <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ“œ Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between ece4822 and 13068db.

β›” Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
πŸ“’ Files selected for processing (1)
  • go.mod (9 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Analyze (go)
  • GitHub Check: Golang-CI (lint)
  • GitHub Check: Unit tests

@rustatian rustatian merged commit ff25363 into master Oct 2, 2025
14 checks passed
@rustatian rustatian deleted the release/v2025.1.4 branch November 13, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants