chore: Remove compile-time checks of sqlx queries#959
Merged
spencewenski merged 3 commits intomainfrom Mar 4, 2026
Merged
Conversation
Because the sqlx queries we perform rely on pgmq being installed, they will fail at compile time for a first-run of the app unless the consumer sets the `SQLX_OFFLINE=true` environment variable. This may not be desirable -- the consumer may want to use sqlx's compile-time checks for the rest of their application. This PR removes the compile-time checks from roadster to resolve this. This is not super ideal as now we do not have compile-time checks of these queries. However, we only have two sqlx queries currently, so if we need to modify them we could temporarily re-add compile-time checks while writing the queries, then remove them again before merging.
Codecov Report❌ Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the sqlx queries we perform rely on pgmq being installed, they will fail at compile time for a first-run of the app unless the consumer sets the
SQLX_OFFLINE=trueenvironment variable. This may not be desirable -- the consumer may want to use sqlx's compile-time checks for the rest of their application.This PR removes the compile-time checks from roadster to resolve this. This is not super ideal as now we do not have compile-time checks of these queries. However, we only have two sqlx queries currently, so if we need to modify them we could temporarily re-add compile-time checks while writing the queries, then remove them again before merging.
See similar PR in the pgmq crate: pgmq/pgmq#463