Fix standalone GUI close race condition and update baseview #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
become_first_responderon macOS (PR avoid crash when window is null in become_first_responder RustAudio/baseview#204)Problem
When closing the standalone app via the GUI (Cmd+Q or clicking X on macOS), there was a race condition where:
Window::open_blocking()returns and theWrapperWindowHandleris dropped_editor_handle, starting editor cleanupSolution
Handle
WindowEvent::WillCloseinWrapperWindowHandler::on_eventto:Also updates baseview from rev
579130ecto237d323cwhich fixes a separate macOS crash during window initialization with newer Rust versions (1.86+).Test plan
gain_gui_vizia)🤖 Generated with Claude Code