fix a race condition and shutdown in the composite Runnable #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Previously, in
runnables/composite/runner.go, theRun()method created a derivedrunCtxbut passed the originalctxtoboot(). Then later,boot()launches child goroutines viastartRunnable(ctx, ...), which callscontext.WithCancel(ctx)per child. Becausectxis the caller's context (notrunCtx), the children are not inrunCtx's cancellation tree.