Skip to content

Fix bug in banout_vprintf#820

Merged
p-l- merged 1 commit intorobertdavidgraham:masterfrom
gpotter2:patch-2
Jun 5, 2025
Merged

Fix bug in banout_vprintf#820
p-l- merged 1 commit intorobertdavidgraham:masterfrom
gpotter2:patch-2

Conversation

@gpotter2
Copy link
Copy Markdown
Contributor

@gpotter2 gpotter2 commented Mar 7, 2025

Not really sure how nobody noticed, but at least on my

gcc version 14.2.0 (Debian 14.2.0-16)

$ ./bin/masscan --selftest
======================================================================
 Segmentation fault: please post this backtrace to:
 https://github.com/robertdavidgraham/masscan/issues
======================================================================
13: [./bin/masscan(+0xa871) [0x55e644345871]]
?? ??:0
[....]

marker is consumed when used in the first vnsprintf, resulting in a segfault in the second. See https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/va-arg-va-copy-va-end-va-start?view=msvc-170

@gpotter2 gpotter2 changed the title Fix segmentation fault in banout_vprintf Fix bug in banout_vprintf Mar 7, 2025
@p-l- p-l- merged commit b99d433 into robertdavidgraham:master Jun 5, 2025
2 checks passed
@gpotter2 gpotter2 deleted the patch-2 branch June 6, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants