Skip to content

fix: Visual Studio build #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshad-k wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

fix: Visual Studio build #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/massip-addr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ int ipv6address_selftest(void)
{"1::2", {.ipv6 = {0x0001000000000000, 0x0000000000000002}, .version = 6}},
{"2::1", {.ipv6 = {0x0002000000000000, 0x0000000000000001}, .version = 6}},
{"1:2::", {.ipv6 = {0x0001000200000000, 0x0000000000000000}, .version = 6}},
{NULL, {{0, 0}, 0}}
Copy link
Author

@anshad-k anshad-k Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC tries to initialize the unsigned ipv4 of the union given in struct ipaddress instead of ipv6address ipv6.
Also can be fixed with just {NULL} here.

Copy link

@Summer20130725 Summer20130725 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the code? I'd like to pull it to my local machine and compile it.

{NULL, {.ipv6 = {0, 0}, .version = 0}}
};

int x = 0;
Expand Down
2 changes: 2 additions & 0 deletions vs10/masscan.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
<ClCompile Include="..\src\templ-tcp-hdr.c" />
<ClCompile Include="..\src\util-checksum.c" />
<ClCompile Include="..\src\util-errormsg.c" />
<ClCompile Include="..\src\util-extract.c" />
<ClCompile Include="..\src\util-logger.c" />
<ClCompile Include="..\src\util-malloc.c" />
<ClCompile Include="..\src\util-safefunc.c" />
Expand Down Expand Up @@ -227,6 +228,7 @@
<ClInclude Include="..\src\util-bool.h" />
<ClInclude Include="..\src\util-checksum.h" />
<ClInclude Include="..\src\util-errormsg.h" />
<ClInclude Include="..\src\util-extract.h" />
<ClInclude Include="..\src\util-logger.h" />
<ClInclude Include="..\src\util-malloc.h" />
<ClInclude Include="..\src\util-safefunc.h" />
Expand Down
6 changes: 6 additions & 0 deletions vs10/masscan.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,9 @@
</ClCompile>
<ClCompile Include="..\src\util-safefunc.c">
<Filter>Source Files\util</Filter>
</ClCompile>
<ClCompile Include="..\src\util-extract.c">
<Filter>Source Files\util</Filter>
</ClCompile>
</ItemGroup>
<ItemGroup>
Expand Down Expand Up @@ -689,6 +692,9 @@
<ClInclude Include="..\src\util-safefunc.h">
<Filter>Source Files\util</Filter>
</ClInclude>
<ClInclude Include="..\src\util-extract.h">
<Filter>Source Files\util</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<None Include="..\README.md" />
Expand Down