Flush output buffer after writing status/banner to stdout#838
Open
elijahr2411 wants to merge 1 commit intorobertdavidgraham:masterfrom
Open
Flush output buffer after writing status/banner to stdout#838elijahr2411 wants to merge 1 commit intorobertdavidgraham:masterfrom
elijahr2411 wants to merge 1 commit intorobertdavidgraham:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, masscan does not call
fflushon the output handle after writing status/banner. When writing output to a file (where buffering is desirable) or to a console (which is not buffered), this is not an issue. However, when piping masscan's output to a script, the output buffering causes the other end of the pipe to not receive any scan results until either enough have been buffered for the handle to flush itself, or otherwise until the scan is complete and the handle is closed.This PR fixes this issue by calling
fflushafter every output write when the output file is stdout.Resolves #533