Adds robust testing and handling of the Numo invariant#1
Merged
robertleifke merged 3 commits intomainfrom Jun 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates various repository configurations, deployment guides, and CI workflows to improve local development, testing, and handling of the Numo invariant while also streamlining several configuration files. Key changes include:
- A new LOCAL_DEPLOYMENT.md guide for manual and automated local development with Anvil.
- Updates to CI workflows with removal of legacy test, gas, and contracts workflows and the addition of a new CI workflow.
- Revamped repository configurations including updated VSCode settings, gitpod, and submodule URL adjustments.
Reviewed Changes
Copilot reviewed 60 out of 60 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LOCAL_DEPLOYMENT.md | Added deployment and troubleshooting guide for Numo hook contract deployment. |
| LICENSE.md / LICENSE | Replaced legacy Business Source License with the MIT License. |
| .vscode/settings.json | Updated formatter and language-specific settings for Solidity and TOML. |
| .solhint.json, .prettierrc(.yml)/.prettierignore | Introduced updated linters and formatting rules across different file types. |
| .gitmodules | Adjusted submodule URLs and configurations. |
| .github/workflows/* | Replaced several workflows with a consolidated CI workflow configuration. |
| .github/scripts/rename.sh | Added a script to dynamically update repository metadata. |
| .gitpod.yml, .devcontainer/* | New development container configurations to streamline setup. |
Comments suppressed due to low confidence (1)
.gitmodules:9
- Please verify that the new URL for the 'lib/uniswap-hooks' submodule is intended, as it differs from the previous repository source.
url = https://github.com/OpenZeppelin/uniswap-hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version had out of date tests and did not properly handle the reserves for swapping. The new version streamlines this with
Numo.solandNumo.t.sol.