Skip to content

Adds robust testing and handling of the Numo invariant#1

Merged
robertleifke merged 3 commits intomainfrom
robert/numo2
Jun 2, 2025
Merged

Adds robust testing and handling of the Numo invariant#1
robertleifke merged 3 commits intomainfrom
robert/numo2

Conversation

@robertleifke
Copy link
Owner

@robertleifke robertleifke commented Jun 2, 2025

The previous version had out of date tests and did not properly handle the reserves for swapping. The new version streamlines this with Numo.sol and Numo.t.sol.

@robertleifke robertleifke requested a review from Copilot June 2, 2025 10:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various repository configurations, deployment guides, and CI workflows to improve local development, testing, and handling of the Numo invariant while also streamlining several configuration files. Key changes include:

  • A new LOCAL_DEPLOYMENT.md guide for manual and automated local development with Anvil.
  • Updates to CI workflows with removal of legacy test, gas, and contracts workflows and the addition of a new CI workflow.
  • Revamped repository configurations including updated VSCode settings, gitpod, and submodule URL adjustments.

Reviewed Changes

Copilot reviewed 60 out of 60 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
LOCAL_DEPLOYMENT.md Added deployment and troubleshooting guide for Numo hook contract deployment.
LICENSE.md / LICENSE Replaced legacy Business Source License with the MIT License.
.vscode/settings.json Updated formatter and language-specific settings for Solidity and TOML.
.solhint.json, .prettierrc(.yml)/.prettierignore Introduced updated linters and formatting rules across different file types.
.gitmodules Adjusted submodule URLs and configurations.
.github/workflows/* Replaced several workflows with a consolidated CI workflow configuration.
.github/scripts/rename.sh Added a script to dynamically update repository metadata.
.gitpod.yml, .devcontainer/* New development container configurations to streamline setup.
Comments suppressed due to low confidence (1)

.gitmodules:9

  • Please verify that the new URL for the 'lib/uniswap-hooks' submodule is intended, as it differs from the previous repository source.
url = https://github.com/OpenZeppelin/uniswap-hooks

@robertleifke robertleifke merged commit 6a7a0f2 into main Jun 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants