Skip to content

Report explicit instantiations that are not yet supported. #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
Merged

Report explicit instantiations that are not yet supported. #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions src/parser/cxx/parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9717,27 +9717,24 @@ auto Parser::parse_explicit_instantiation(DeclarationAST*& yyast) -> bool {
if (!parse_declaration(ast->declaration, BindingContext::kTemplate))
parse_error("expected a declaration");

auto check_elaborated_type_specifier = [&] {
if (!config().checkTypes) return;

auto check_elaborated_type_specifier = [&]() -> bool {
auto simpleDecl = ast_cast<SimpleDeclarationAST>(ast->declaration);
if (!simpleDecl) return;
if (!simpleDecl) return false;

if (!simpleDecl->declSpecifierList) return;
if (!simpleDecl->declSpecifierList) return false;

auto elabSpec = ast_cast<ElaboratedTypeSpecifierAST>(
simpleDecl->declSpecifierList->value);
if (!elabSpec) {
type_error(currentLocation(), "expected an elaborated type specifier");
return;
return false;
}

if (elabSpec->nestedNameSpecifier) {
auto templateId = ast_cast<SimpleTemplateIdAST>(elabSpec->unqualifiedId);
if (!templateId) {
type_error(elabSpec->unqualifiedId->firstSourceLocation(),
"expected a template id");
return;
return true;
}

auto candidate = Lookup{scope()}.qualifiedLookup(
Expand All @@ -9746,7 +9743,7 @@ auto Parser::parse_explicit_instantiation(DeclarationAST*& yyast) -> bool {
if (!is_template(candidate)) {
type_error(elabSpec->unqualifiedId->firstSourceLocation(),
std::format("expected a template"));
return;
return true;
}

auto classSymbol = symbol_cast<ClassSymbol>(candidate);
Expand All @@ -9755,37 +9752,48 @@ auto Parser::parse_explicit_instantiation(DeclarationAST*& yyast) -> bool {
elabSpec->unqualifiedId->firstSourceLocation(),
std::format("expected a class template, got '{}'",
to_string(candidate->type(), candidate->name())));
return;
return true;
}

auto instance = ASTRewriter::instantiateClassTemplate(
unit, templateId->templateArgumentList, classSymbol);
if (config().checkTypes) {
auto instance = ASTRewriter::instantiateClassTemplate(
unit, templateId->templateArgumentList, classSymbol);

return;
(void)instance;
}

return true;
}

auto templateId = ast_cast<SimpleTemplateIdAST>(elabSpec->unqualifiedId);
if (!templateId) {
type_error(elabSpec->unqualifiedId->firstSourceLocation(),
"expected a template id");
return;
return true;
}

auto classSymbol = symbol_cast<ClassSymbol>(templateId->symbol);
if (!classSymbol) {
type_error(
templateId->identifierLoc,
"explicit instantiation of this template is not yet supported");
return;
return true;
}

auto instance = ASTRewriter::instantiateClassTemplate(
unit, templateId->templateArgumentList, classSymbol);
if (config().checkTypes) {
auto instance = ASTRewriter::instantiateClassTemplate(
unit, templateId->templateArgumentList, classSymbol);

(void)instance;
}

(void)instance;
return true;
};

check_elaborated_type_specifier();
if (check_elaborated_type_specifier()) return true;

// todo: handle other template kinds
type_error(ast->firstSourceLocation(), "failed to instantiate template");

return true;
}
Expand Down
Loading