added(docs): clarify base OT message security#50
Merged
robinhundt merged 1 commit intomainfrom Feb 2, 2026
Merged
Conversation
robinhundt
force-pushed
the
clarify-base-message-security
branch
from
83e046c to
b43a41f
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates documentation for the Simplest-OT base OT protocol implementation to clarify its message security properties using terminology from the MR19 paper, addressing discussion from issue #48.
Changes:
- Enhanced module-level documentation to specify "uniform message security" guarantee
- Added detailed inline comments explaining the seed commitment mechanism
- Added citation links for both CO15 and MR19 papers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cryprot-ot/src/base.rs
Outdated
| //! Simplest-OT base OT protocol by [[CO15](https://eprint.iacr.org/2015/267)] (malicious security). | ||
| //! Simplest-OT base OT protocol by [[CO15]] (malicious security). | ||
| //! | ||
| //! This module implements the Simplest OT protocol described in in [[CO15]] |
There was a problem hiding this comment.
Corrected duplicate word 'in in' to 'in'.
Suggested change
| //! This module implements the Simplest OT protocol described in in [[CO15]] | |
| //! This module implements the Simplest OT protocol described in [[CO15]] |
cryprot-ot/src/base.rs
Outdated
| let a = Scalar::random(&mut RngCompat(&mut self.rng)); | ||
| let mut A = RISTRETTO_BASEPOINT_TABLE * &a; | ||
| // The usual CO15 protocol only provides receiver chosen message security. | ||
| // To ensure the OTs are uniformly distributed, the sender samples a random sees |
There was a problem hiding this comment.
Corrected spelling of 'sees' to 'seed'.
Suggested change
| // To ensure the OTs are uniformly distributed, the sender samples a random sees | |
| // To ensure the OTs are uniformly distributed, the sender samples a random seed |
Based on the discussion in #48 this clarifies the message security of the CO15 base OT implementation using the terminology of MR19.
robinhundt
force-pushed
the
clarify-base-message-security
branch
from
b43a41f to
e4d8ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #48 this clarifies the message security of the CO15 base OT implementation using the terminology of MR19.