Sync activity type tabs across metric pills for improved user experience#1857
Closed
lennon101 wants to merge 8 commits intorobiningelbrecht:masterfrom
Closed
Sync activity type tabs across metric pills for improved user experience#1857lennon101 wants to merge 8 commits intorobiningelbrecht:masterfrom
lennon101 wants to merge 8 commits intorobiningelbrecht:masterfrom
Conversation
lennon101
changed the title
Owner
|
@lennon101 will you finish this PR or what is the plan here? |
Contributor
Author
|
Yeah sorry man! Been meaning to get back to it just haven't had the time. I got stuck on trying to get some of the checks to pass 🤦♂️ |
Owner
|
Don't worry about the checks, I'll fix them. |
Contributor
Author
|
I'm not able to get this running correctly and I'm well aware I'm running behind :( I will submit for review and maybe if you like the idea you can fix any issues you find with it. I haven't explained it very well in the initial issue but here's a better explanation if the issue wasn't clear enough: 
|
lennon101
changed the title
Owner
|
@lennon101 I decided to not merge this. The added complexity for one extra click is just to high |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixes #1856