Skip to content

ISSUE #1861: Improve milestones mobile layout #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robiningelbrecht merged 2 commits into from
Mar 7, 2026
Merged

ISSUE #1861: Improve milestones mobile layout #1862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e039c
ISSUE #1861: Improve milestones mobile layout
robiningelbrecht Mar 7, 2026
19caf17
Merge branch 'master' into ISSUE-1861
robiningelbrecht Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/css/dist/tailwind.min.css
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions public/css/tailwind.output.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3971,6 +3971,12 @@
line-height: var(--tw-leading, var(--text-4xl--line-height));
}
}
.md\:text-base {
@media (width >= 48rem) {
font-size: var(--text-base);
line-height: var(--tw-leading, var(--text-base--line-height));
}
}
.md\:text-lg {
@media (width >= 48rem) {
font-size: var(--text-lg);
Expand Down
8 changes: 4 additions & 4 deletions templates/html/milestones.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@
<div class="p-4 bg-white border border-gray-200 rounded-lg shadow-xs">
<div class="flex items-center gap-x-1 mb-1">
{% if milestone.getSportType() %}
<div class="px-2 py-0.5 text-xxs font-medium border border-gray-200 text-strava-orange bg-white rounded-lg">
<div class="shrink-0 px-2 py-0.5 text-xxs font-medium border border-gray-200 text-strava-orange bg-white rounded-lg">
{{ milestone.getSportType()|trans }}
</div>
{% endif %}
<h3 class="text-base font-bold text-gray-900">{{ _self.milestoneTitle(milestone) }}</h3>
<h3 class="text-sm md:text-base font-bold text-gray-900 truncate">{{ _self.milestoneTitle(milestone) }}</h3>
</div>
<div class="text-sm text-gray-600">
{% if milestone.getActivityId() %}
Expand All @@ -66,12 +66,12 @@
{% endif %}
</div>
{% if milestone.getFunComparison() %}
<div class="mt-1 text-sm italic text-gray-500">
<div class="mt-1 text-sm italic text-gray-500 truncate">
{{ milestone.getFunComparison()|trans }}
</div>
{% endif %}
{% if milestone.getCategory() == enum('App\\Domain\\Milestone\\MilestoneCategory').EDDINGTON %}
<div class="mt-1 text-sm italic text-gray-500">
<div class="mt-1 text-sm italic text-gray-500 truncate">
{{ "That's {number} days of at least {distance}"|trans({
'{number}': milestone.getContext().getNumber(),
'{distance}': milestone.getContext().getDistance()|renderMeasurement(0)})|raw
Expand Down
Loading