Skip to content

feat(weekly-stats): add load to weekly stats widget#1866

Closed
hutchinsp01 wants to merge 2 commits intorobiningelbrecht:masterfrom
hutchinsp01:feat/add-load-to-weekly-stats
Closed

feat(weekly-stats): add load to weekly stats widget#1866
hutchinsp01 wants to merge 2 commits intorobiningelbrecht:masterfrom
hutchinsp01:feat/add-load-to-weekly-stats

Conversation

@hutchinsp01
Copy link
Copy Markdown
Contributor

@hutchinsp01 hutchinsp01 commented Mar 8, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Improvement
  • Translations
  • Documentation Update

Description

Add's LOAD to the Weekly stats widget, useful for comparing week to week training.

image

Note

I had a look for tests for the weekly stats widget, but could only find the ones I've updated.
lmk if you want tests for the metrics individually

BREAKING CHANGES

  • Requires updating dashboard config to include this 'metricsDisplayOrder': ['distance', 'movingTime', 'elevation', 'load'] } }

Fixes ISSUE_NUMBER

@robiningelbrecht
Copy link
Copy Markdown
Owner

@hutchinsp01 thanks for your PR. I noticed that there is a breaking change. Breaking changes imply that we need to release a new major version.
I don't want to release a naw major version for this improvement. Can you make this change backwards compatible?

@robiningelbrecht
Copy link
Copy Markdown
Owner

In terms of stats, does it make sense to have this training load per week number?

@hutchinsp01
Copy link
Copy Markdown
Contributor Author

Hey, yep I'll make it backwards compatible. I assume it's okay to just add a fallback if only 3 values are provided to the config.

In terms of if this is needed for stats, it's quite useful to compare week to week your training load for seeing whether or not you are over-training.

I used to use the Strava premium load chart, but have since stopped paying for it and is something I used frequently.

It is very similar to the Training Load Analysis, so maybe it makes more sense showing it there? But currently there is no where I can see the weekly TRIMP historically to compare. And this seemed like the most reasonable place to show it

@robiningelbrecht
Copy link
Copy Markdown
Owner

robiningelbrecht commented Mar 9, 2026

@hutchinsp01 we only keep track of the training load for YTD. This means that the weekly stats chart will stop showing "load" data once you go back more than 1 year. That's not ideal.
I think it would make more sense to integrate this is the training load indeed

@hutchinsp01
Copy link
Copy Markdown
Contributor Author

Closing for now, will rethink how to integrate into Training Load analysis

@hutchinsp01 hutchinsp01 closed this Mar 9, 2026
@robiningelbrecht
Copy link
Copy Markdown
Owner

robiningelbrecht commented Mar 9, 2026

What about an extra tab here?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants