brokeit #39
Open
brokeit #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| my_var="some value" | ||
| [ -f $my_var ] | ||
| echo "hello" > /dev/stderr | ||
| if [ "$foo" = 1 ]; then |
| my_var="some value" | ||
| [ -f $my_var ] | ||
| echo "hello" > /dev/stderr | ||
| if [ "$foo" = 1 ]; then |
There was a problem hiding this comment.
🚫 [shellcheck] reported by reviewdog 🐶
Expected 'fi' matching previously mentioned 'if'. SC1047
kroxylicious/scripts/common.sh
Line 81 in 7b17e12
There was a problem hiding this comment.
🚫 [shellcheck] reported by reviewdog 🐶
Expected 'fi'. Fix any mentioned problems and try again. SC1072
kroxylicious/scripts/common.sh
Line 81 in 7b17e12
9 tasks
The github permissions are currently blocking PRs from forks from writing checks/review commands. We cannot use workflow permissions to give write permissions to runs from forks. Options are to shuffle the work into a workflow_run triggered after the lint, so we can use the workflow_permissions. Or use pull_request_target. Or use a PAT with write permissions. Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Please describe your pull request
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done