Skip to content

Comments

Fix handling of invalid annotation descriptions and add tests to dataset uploads#367

Merged
shntu merged 2 commits intomainfrom
sb/debug-import
Mar 25, 2025
Merged

Fix handling of invalid annotation descriptions and add tests to dataset uploads#367
shntu merged 2 commits intomainfrom
sb/debug-import

Conversation

@shntu
Copy link
Contributor

@shntu shntu commented Mar 25, 2025

Description

This PR fixes a user-reported bug that occurs when uploading a dataset - sometimes, annotation data is an empty string for an image and causes uploads to fail with the following error:

[ERR] grain-multi/datasets/train/images/0011.png ('str' object has no attribute 'get')

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Added unit tests, also tested locally with a dataset

Any specific deployment considerations

No

Docs

N/A

@shntu shntu requested review from lrosemberg and tonylampada March 25, 2025 14:18
Copy link
Contributor

@lrosemberg lrosemberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shntu shntu merged commit f40a653 into main Mar 25, 2025
8 checks passed
@shntu shntu deleted the sb/debug-import branch March 25, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants