Skip to content

Conversation

@Borda
Copy link
Member

@Borda Borda commented Jan 7, 2026

This pull request makes a minor update to the linting configuration in pyproject.toml by enabling an additional linting rule group.

  • Added "PT" to the select list in the [tool.ruff.lint] section to enable the corresponding linting rules.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52%. Comparing base (f1e0c9c) to head (62fa008).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2053   +/-   ##
=======================================
  Coverage       52%     52%           
=======================================
  Files           61      61           
  Lines         7076    7076           
=======================================
  Hits          3657    3657           
  Misses        3419    3419           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda marked this pull request as ready for review January 13, 2026 18:08
@Borda Borda requested a review from SkalskiP as a code owner January 13, 2026 18:08
Copilot AI review requested due to automatic review settings January 13, 2026 18:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enables pytest-style linting rules in the project by adding the "PT" rule group to Ruff's linting configuration. This enforcement led to automated fixes across test files to comply with pytest best practices, specifically around parameterized test formatting.

Changes:

  • Added pytest linting rules ("PT") to Ruff configuration
  • Refactored pytest.mark.parametrize decorators to use tuple syntax instead of string literals
  • Replaced assert False with pytest.fail() for clearer test failure messages
  • Removed duplicate test cases
  • Added PT011 to ignored rules for test files (overly broad exception matching)

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Added "PT" rule group and PT011 exception ignore for tests
supervision/detection/vlm.py Replaced assert False with pytest.fail() in production code
test/**/*.py Converted parametrize arguments from strings to tuples and removed duplicate test cases
Comments suppressed due to low confidence (1)

test/dataset/formats/test_yolo.py:40

  • A duplicate test case for single line with box was removed (the remaining case at lines 38-41 duplicates the removed one). However, this appears to be intentional cleanup. Verify that the removed test case at line 47 (which was marked as removed in the diff) didn't provide unique coverage compared to the remaining test at lines 38-41.
            ["0 0.5 0.5 0.2 0.2"],
            False,
            DoesNotRaise(),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Jan 13, 2026

@Borda I've opened a new pull request, #2077, to work on those changes. Once the pull request is ready, I'll request review from you.

@Borda Borda merged commit 09de0f4 into develop Jan 13, 2026
26 checks passed
@Borda Borda deleted the ruff/PT branch January 13, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants