ci: Remove conflicted removeOnDirtyLabel from PR labeling
#2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a configuration issue in the PR conflict labeling workflow by removing the incorrectly configured removeOnDirtyLabel parameter. The parameter was redundantly set to the same value as dirtyLabel ("has conflicts"), which creates a logical conflict. The action automatically handles removing the dirty label when conflicts are resolved, making this parameter unnecessary.
Changes:
- Removed the
removeOnDirtyLabelparameter from the PR conflict labeler workflow configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Borda
changed the title
removeOnDirtyLabel parameter from PR conflict lab…removeOnDirtyLabel from PR conflict labeling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2092 +/- ##
=======================================
Coverage 52% 52%
=======================================
Files 61 61
Lines 7076 7076
=======================================
Hits 3657 3657
Misses 3419 3419 🚀 New features to boost your workflow:
|
Borda
changed the title
removeOnDirtyLabel from PR conflict labelingremoveOnDirtyLabel from PR labeling
SkalskiP
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the pull request conflict labeling workflow by removing the
removeOnDirtyLabelconfiguration from the.github/workflows/pr-conflict-labeler.ymlfile. This simplifies the workflow configuration.The
removeOnDirtyLabelparameter is configured with the same value asdirtyLabel. This parameter should specify labels to remove when a PR becomes dirty (has conflicts), not the label that indicates conflicts. Setting both to "has conflicts" creates a logical conflict. Either remove this parameter entirely (the action automatically removesdirtyLabelwhen conflicts are resolved), or set it to a different label like "ready to merge" if you want to remove that label when conflicts appear.