Resolve tag patterns in workflows for consistency#209
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix tag matching patterns in GitHub Actions workflows for publishing releases and pre-releases to PyPI. The changes modify the patterns to better match semantic version tags by removing redundant pattern segments.
Changes:
- Simplified release tag pattern from
[0-9]+.[0-9]+[0-9]+.[0-9]to[0-9]+.[0-9]+.[0-9]in publish-release.yml - Updated pre-release tag patterns to use three version components instead of four, and added support for dot-separated pre-release identifiers (e.g.,
1.2.3.a1)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/publish-release.yml | Updated tag pattern to match X.Y.Z format versions by removing redundant pattern segment |
| .github/workflows/publish-pre-release.yml | Corrected and expanded pre-release tag patterns to match both 1.2.3a1 and 1.2.3.a1 style tags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the tag matching patterns in the GitHub Actions workflows responsible for publishing releases and pre-releases to PyPI. The changes correct the regular expressions so that version tags are properly recognized and handled by the workflows.
Workflow trigger improvements:
.github/workflows/publish-release.ymlto correctly match standard release tags in the formatX.Y.Z(e.g.,1.2.3)..github/workflows/publish-pre-release.ymlto properly match pre-release tags (alpha, beta, release candidate) with and without a separating dot, such as1.2.3a1,1.2.3.a1,1.2.3b1,1.2.3.b1, etc.