First refactor of cl_gcalcli and sm_cl_gcalcli_test_1#702
Merged
Conversation
Contributor
|
This pull request is in conflict. Could you fix it @brettpac? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed CbEventDetect to CbDetectCalendarEvent for consistency with SMACC2 naming conventions (e.g., CbDetectApriltag). Updated all references in client library, test state machine, and documentation.
Added CbDetectCalendarEvent Parameters section to README explaining the minutes_before parameter that controls early triggering relative to event start time.
Changed default minutes_before from 5 to 0 in test state machine so events trigger at actual start time.