Skip to content

Commit 3e5a909

Browse files
rasjaniaaltat
authored andcommitted
EventFiringWebElement support for ElementFinder
Fixes #1538
1 parent dff49b8 commit 3e5a909

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

atest/acceptance/2-event_firing_webdriver/event_firing_webdriver.robot

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@ Event Firing Webdriver Input Text (WebElement)
3131
... LOG 1:14 INFO After clear and send_keys
3232
Input Text //input[@name="textfield"] FooBar
3333

34-
Event Firing Webdriver Click Element (WebElement)
34+
Event Firing Webdriver With Get WebElement (WebElement)
3535
[Tags] NoGrid
36-
[Documentation]
37-
... LOG 1:5 INFO Before click
38-
... LOG 1:9 INFO After click
39-
Click Element //input[@name="ok_button"]
36+
Go To ${ROOT}/nested_divs.html
37+
${link}= Get WebElement //a[@id="needleC"]
38+
Wait Until Element Contains ${link} top/c/needle

src/SeleniumLibrary/locators/elementfinder.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from robot.api import logger
1818
from robot.utils import NormalizedDict
1919
from selenium.webdriver.remote.webelement import WebElement
20+
from selenium.webdriver.support.event_firing_webdriver import EventFiringWebElement
2021

2122
from SeleniumLibrary.base import ContextAware
2223
from SeleniumLibrary.errors import ElementNotFound
@@ -102,7 +103,7 @@ def unregister(self, strategy_name):
102103

103104
def _is_webelement(self, element):
104105
# Hook for unit tests
105-
return isinstance(element, WebElement)
106+
return isinstance(element, (WebElement, EventFiringWebElement))
106107

107108
def _disallow_webelement_parent(self, element):
108109
if self._is_webelement(element):

0 commit comments

Comments
 (0)